-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated tch-rs to 0.13.0 #380
Conversation
find replaced of_slice to from_slice as per https://github.com/LaurentMazare/tch-rs/blob/008fff6cc0a91ecff274d1549c2dff25b8ca57a4/CHANGELOG.md
A nice addition on 0.13.0 is that the Also note that the automated libtorch download is now opt-out, you can get the old behavior with the specific cargo feature though probably better to avoid it if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @LaurentMazare for the note - these look like good changes indeed and will hopefully make the installation on mac / M1 targets easier. I have copied over the build script from diffusers-rs/build.rs, I hope that is fine.
@josephhajduk @guillaume-be This is breaking the build of Indexify - https://github.com/diptanu/indexify Any suggestions for how to fix it? |
I had to explicitly add a direct torch-sys dependency to my project with the download-libtorch feature. It didn't seem to work by adding the feature to the bert-rs dependency. |
@diptanu @josephhajduk could you please try to check the branch candidate at #382 without passing |
@guillaume-be @josephhajduk I responded on the issue - PyO3 broke the build for me, I updated to the new master of rust-bert and added PyO3 which caused the confusion. I see that new PR has been merged related to the libtorch download feature, will test it soon but I got around to solving the issue by adding a dependency to tch directly. |
find replaced of_slice to from_slice as per
https://github.com/LaurentMazare/tch-rs/blob/008fff6cc0a91ecff274d1549c2dff25b8ca57a4/CHANGELOG.md
was having trouble running on m1 with 0.12.0, works with 0.13.0