README - macOS installation, validating installation #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "manual installation" section of the README only has Linux and Windows examples, and I had to dig through issues to figure out how to get rust-bert working on macOS (Apple Silicon). This adds "macOS + Homebrew" to the manual installation section. Most macOS users building in Rust would consider it fair to call installing pytorch via Homebrew "manual" installation" (trying to avoid pyenv, pip, etc.)
|
Credit to @knpwrs in #326 (comment) for providing the actual code 🙏 |
There was a problem hiding this comment.
Thank you @aguynamedben for adding the instructions for macOS. I have added a small comment since we technically link to libtorch - please let me know what you think
|
@guillaume-be lgtm, thank you for working on this great crate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "manual installation" section of the README only has Linux and Windows examples, and I had to dig through issues to figure out how to get rust-bert working on macOS (Apple Silicon).
This adds "macOS + Homebrew" to the manual installation section. Most macOS users building in Rust would consider it fair to call installing pytorch via Homebrew "manual" installation" (trying to avoid pyenv, pip, etc.)