Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump liftoff and v8flags #11

Merged
merged 1 commit into from
Jan 18, 2015
Merged

bump liftoff and v8flags #11

merged 1 commit into from
Jan 18, 2015

Conversation

tkellen
Copy link

@tkellen tkellen commented Jan 15, 2015

this should solve all of the wack installation issues we were
seeing on windows machines, and work correctly with io.js.

  • v8flags is now async
  • v8flags caches flags at first run, not on installation
  • liftoff nodeFlags was renamed to v8flags for accuracy

this should solve all of the wack installation issues we were
seeing on windows machines, and work correctly with io.js.

- v8flags is now async
- v8flags caches flags at first run, not on installation
- liftoff `nodeFlags` was renamed to `v8flags` for accuracy
@yocontra
Copy link
Member

Failed ^

@phated
Copy link
Member

phated commented Jan 15, 2015

We are still waiting for some changes. That being said, I have no idea why appveyor started failing again. Maybe @heikki can take a look?

@heikki
Copy link
Contributor

heikki commented Jan 15, 2015

Install fails because 6to5 has kexec as optionalDependency and that doesn't support windows. But..

If a dependency can be used, but you would like npm to proceed if it cannot be found or fails to install, then you may put it in the optionalDependencies object.

Could it be that npm is too old or something?

ps. I'm no windows expert, just making sure I don't have to use ant etc. ever in mixed os projects 😄

@phated
Copy link
Member

phated commented Jan 15, 2015

@heikki installation isn't failing on appveyor, it seems to be a stdout problem again.

@heikki
Copy link
Contributor

heikki commented Jan 15, 2015

Ah, sorry. Didn't read carefully enough.

@heikki
Copy link
Contributor

heikki commented Jan 15, 2015

It's not only this PR. Current master fails too and even the commit where I "fixed" things originally. Either some sub-sub-dependency has changed something or I'm going crazy. I'll see if I can make more sense out of it tomorrow.

@phated
Copy link
Member

phated commented Jan 17, 2015

holding off on this until @tkellen bumps again.

@tkellen
Copy link
Author

tkellen commented Jan 17, 2015

I'm not in front of my laptop right now--feel free to push a new release,
or I will when I get home (2-3 hours).
On Jan 17, 2015 2:18 PM, "Blaine Bublitz" notifications@github.com wrote:

holding off on this until @tkellen https://github.com/tkellen bumps
again.


Reply to this email directly or view it on GitHub
#11 (comment).

@phated
Copy link
Member

phated commented Jan 17, 2015

@tkellen I don't have access to v8flags. I'm fine waiting awhile, no hurry.

@tkellen
Copy link
Author

tkellen commented Jan 18, 2015

2.0.2 released.

@phated
Copy link
Member

phated commented Jan 18, 2015

Woot, merging and bumping these

phated added a commit that referenced this pull request Jan 18, 2015
@phated phated merged commit 73b43b4 into gulpjs:master Jan 18, 2015
@heikki
Copy link
Contributor

heikki commented Jan 19, 2015

I didn't find any reason why windows tests started failing. What's more bizarre is that now they seem to pass again.

phated added a commit that referenced this pull request Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants