-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump liftoff and v8flags #11
Conversation
this should solve all of the wack installation issues we were seeing on windows machines, and work correctly with io.js. - v8flags is now async - v8flags caches flags at first run, not on installation - liftoff `nodeFlags` was renamed to `v8flags` for accuracy
Failed ^ |
We are still waiting for some changes. That being said, I have no idea why appveyor started failing again. Maybe @heikki can take a look? |
Install fails because 6to5 has kexec as optionalDependency and that doesn't support windows. But..
Could it be that npm is too old or something? ps. I'm no windows expert, just making sure I don't have to use ant etc. ever in mixed os projects 😄 |
@heikki installation isn't failing on appveyor, it seems to be a stdout problem again. |
Ah, sorry. Didn't read carefully enough. |
It's not only this PR. Current master fails too and even the commit where I "fixed" things originally. Either some sub-sub-dependency has changed something or I'm going crazy. I'll see if I can make more sense out of it tomorrow. |
holding off on this until @tkellen bumps again. |
I'm not in front of my laptop right now--feel free to push a new release,
|
@tkellen I don't have access to |
|
Woot, merging and bumping these |
I didn't find any reason why windows tests started failing. What's more bizarre is that now they seem to pass again. |
this should solve all of the wack installation issues we were
seeing on windows machines, and work correctly with io.js.
nodeFlags
was renamed tov8flags
for accuracy