Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register any function that is exported from a gulpfile #47

Merged
merged 2 commits into from
Dec 18, 2015
Merged

Conversation

phated
Copy link
Member

@phated phated commented Dec 18, 2015

@thejameskyle As per gulpjs/gulp/issues/1305 - can you try this out?

@contra you good with this functionality being added?

@jamiebuilds
Copy link

Tried getting this working, and wasn't able to https://github.com/thejameskyle/__gulp-exports

Not sure if I'm missing something. I'm depending on this branch: https://github.com/thejameskyle/__gulp-exports/blob/master/package.json#L16

@phated
Copy link
Member Author

phated commented Dec 18, 2015

@thejameskyle I didn't add it for gulp 3.9 but maybe I could/should

@jamiebuilds
Copy link

It doesn't work for 4.0 either: https://github.com/thejameskyle/__gulp-exports/tree/4.0

@phated
Copy link
Member Author

phated commented Dec 18, 2015

@thejameskyle yeah, digging into it...npm doesn't seem to know how to dedupe github dependencies, so you end up with the gulp-cli#4.0 branch as a dependency of gulp, which is used instead of the gulp-cli you install as a dep

@phated
Copy link
Member Author

phated commented Dec 18, 2015

@thejameskyle deleting node_modules/gulp/node_modules/gulp-cli allows it to work

@jamiebuilds
Copy link

Ah yup, manually running npm dedupe works too. Thanks! This is awesome

@yocontra
Copy link
Member

Yeah this makes perfect sense

@phated
Copy link
Member Author

phated commented Dec 18, 2015

Was easy enough to backport too! 3.7 and up will support this if someone is using this CLI separately

phated added a commit that referenced this pull request Dec 18, 2015
register any function that is exported from a gulpfile
@phated phated merged commit d4b85a2 into 1.1 Dec 18, 2015
@phated phated deleted the register-exports branch December 18, 2015 23:45
@phated phated restored the register-exports branch December 18, 2015 23:51
@phated phated deleted the register-exports branch June 13, 2016 21:06
phated added a commit that referenced this pull request Dec 21, 2017
register any function that is exported from a gulpfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants