Merge pull request #11 from gurukami/dev

ineffassign & golint

int_test.go

@@ -57,7 +57,8 @@ func init() {
 	matrixSuite.SetConverters(intReflectTypes, boolReflectTypes, intBoolConverter)
 	// - to complex
 	intComplexConverter := func(from interface{}, to reflect.Type, opts ...interface{}) (interface{}, bool) {
-		rv, c, s := reflect.ValueOf(from), complex128(0), false
+		var s bool
+		rv, c := reflect.ValueOf(from), complex128(0)
 		i := rv.Int()
 		if s = isSafeIntToFloat(i, bitSizeMap[to.Kind()]); s {
 			c = complex(float64(i), 0)
@@ -73,7 +74,8 @@ func init() {
 	matrixSuite.SetConverters(intReflectTypes, complexReflectTypes, intComplexConverter)
 	// - to float
 	intFloatConverter := func(from interface{}, to reflect.Type, opts ...interface{}) (interface{}, bool) {
-		rv, f, s := reflect.ValueOf(from), float64(0), false
+		var s bool
+		rv, f := reflect.ValueOf(from), float64(0)
 		i := rv.Int()
 		if s = isSafeIntToFloat(i, bitSizeMap[to.Kind()]); s {
 			f = float64(i)

null_bool.go

@@ -89,9 +89,9 @@ func (n BoolCommon) Err() error {
 	return n.Error
 }
 
-// BoolAccessor
+// BoolAccessor accessor of bool type.
 type BoolAccessor interface {
-	NullCommon
+	Common
 	V() bool
 	Set(value bool)
 	Clone() BoolAccessor

null_common.go

@@ -1,7 +1,7 @@
 package typ
 
-// NullCommon
-type NullCommon interface {
+// Common general interface of accessor
+type Common interface {
 	Present() bool
 	Valid() bool
 	Typ(options ...Option) *Type

null_complex.go

@@ -101,9 +101,9 @@ func (n ComplexCommon) Err() error {
 	return n.Error
 }
 
-// ComplexAccessor
+// ComplexAccessor accessor of complex128 type.
 type ComplexAccessor interface {
-	NullCommon
+	Common
 	V() complex128
 	Set(value complex128)
 	Clone() ComplexAccessor
@@ -272,9 +272,9 @@ func (n Complex64Common) Err() error {
 	return n.Error
 }
 
-// Complex64Accessor
+// Complex64Accessor accessor of complex64 type.
 type Complex64Accessor interface {
-	NullCommon
+	Common
 	V() complex64
 	Set(value complex64)
 	Clone() Complex64Accessor

null_float.go

@@ -5,7 +5,7 @@ import (
 	"encoding/json"
 )
 
-// Float32 represents a float32 that may be null.
+// Float32Common represents a float32 that may be null.
 type Float32Common struct {
 	P     *float32
 	Error error
@@ -99,9 +99,9 @@ func (n Float32Common) Err() error {
 	return n.Error
 }
 
-// Float32Accessor
+// Float32Accessor accessor of float32 type.
 type Float32Accessor interface {
-	NullCommon
+	Common
 	V() float32
 	Set(value float32)
 	Clone() Float32Accessor
@@ -264,9 +264,9 @@ func (n FloatCommon) Err() error {
 	return n.Error
 }
 
-// FloatAccessor
+// FloatAccessor accessor of float64 type.
 type FloatAccessor interface {
-	NullCommon
+	Common
 	V() float64
 	Set(value float64)
 	Clone() FloatAccessor

null_int.go

@@ -103,9 +103,9 @@ func (n IntCommon) Err() error {
 	return n.Error
 }
 
-// IntAccessor
+// IntAccessor accessor of int type.
 type IntAccessor interface {
-	NullCommon
+	Common
 	V() int
 	Set(value int)
 	Clone() IntAccessor
@@ -274,9 +274,9 @@ func (n Int8Common) Err() error {
 	return n.Error
 }
 
-// Int8Accessor
+// Int8Accessor accessor of int8 type.
 type Int8Accessor interface {
-	NullCommon
+	Common
 	V() int8
 	Set(value int8)
 	Clone() Int8Accessor
@@ -318,7 +318,7 @@ func NInt8(value int8) Int8Accessor {
 	return &NullInt8{Int8Common{P: &value}}
 }
 
-// NotNullInt represents an int8 with accessor.
+// NotNullInt8 represents an int8 with accessor.
 type NotNullInt8 struct {
 	Int8Common
 }
@@ -445,9 +445,9 @@ func (n Int16Common) Err() error {
 	return n.Error
 }
 
-// Int16Accessor
+// Int16Accessor accessor of int16 type.
 type Int16Accessor interface {
-	NullCommon
+	Common
 	V() int16
 	Set(value int16)
 	Clone() Int16Accessor
@@ -616,9 +616,9 @@ func (n Int32Common) Err() error {
 	return n.Error
 }
 
-// Int32Accessor
+// Int32Accessor accessor of int32 type.
 type Int32Accessor interface {
-	NullCommon
+	Common
 	V() int32
 	Set(value int32)
 	Clone() Int32Accessor
@@ -790,9 +790,9 @@ func (n Int64Common) Err() error {
 	return n.Error
 }
 
-// Int64Accessor
+// Int64Accessor accessor of int64 type.
 type Int64Accessor interface {
-	NullCommon
+	Common
 	V() int64
 	Set(value int64)
 	Clone() Int64Accessor

null_interface.go

@@ -84,9 +84,9 @@ func (n InterfaceCommon) Err() error {
 	return n.Error
 }
 
-// InterfaceAccessor
+// InterfaceAccessor accessor of interface{} type.
 type InterfaceAccessor interface {
-	NullCommon
+	Common
 	V() interface{}
 	Set(value interface{})
 	Clone() InterfaceAccessor

null_string.go

@@ -93,9 +93,9 @@ func (n StringCommon) Err() error {
 	return n.Error
 }
 
-// StringAccessor
+// StringAccessor accessor of string type.
 type StringAccessor interface {
-	NullCommon
+	Common
 	V() string
 	Set(value string)
 	Clone() StringAccessor

null_time.go

@@ -78,9 +78,9 @@ func (n TimeCommon) Err() error {
 	return n.Error
 }
 
-// TimeAccessor
+// TimeAccessor accessor of time.Time type.
 type TimeAccessor interface {
-	NullCommon
+	Common
 	V() time.Time
 	Set(value time.Time)
 	Clone() TimeAccessor

null_uint.go

@@ -104,9 +104,9 @@ func (n UintCommon) Err() error {
 	return n.Error
 }
 
-// UintAccessor
+// UintAccessor accessor of uint type.
 type UintAccessor interface {
-	NullCommon
+	Common
 	V() uint
 	Set(value uint)
 	Clone() UintAccessor
@@ -275,9 +275,9 @@ func (n Uint8Common) Err() error {
 	return n.Error
 }
 
-// Uint8Accessor
+// Uint8Accessor accessor of uint8 type.
 type Uint8Accessor interface {
-	NullCommon
+	Common
 	V() uint8
 	Set(value uint8)
 	Clone() Uint8Accessor
@@ -319,7 +319,7 @@ func NUint8(value uint8) Uint8Accessor {
 	return &NullUint8{Uint8Common{P: &value}}
 }
 
-// NotNullUint represents an uint8 with accessor.
+// NotNullUint8 represents an uint8 with accessor.
 type NotNullUint8 struct {
 	Uint8Common
 }
@@ -446,9 +446,9 @@ func (n Uint16Common) Err() error {
 	return n.Error
 }
 
-// Uint16Accessor
+// Uint16Accessor accessor of uint16 type.
 type Uint16Accessor interface {
-	NullCommon
+	Common
 	V() uint16
 	Set(value uint16)
 	Clone() Uint16Accessor
@@ -617,9 +617,9 @@ func (n Uint32Common) Err() error {
 	return n.Error
 }
 
-// Uint32Accessor
+// Uint32Accessor accessor of uint32 type.
 type Uint32Accessor interface {
-	NullCommon
+	Common
 	V() uint32
 	Set(value uint32)
 	Clone() Uint32Accessor
@@ -792,9 +792,9 @@ func (n Uint64Common) Err() error {
 	return n.Error
 }
 
-// Uint64Accessor
+// Uint64Accessor accessor of uint64 type.
 type Uint64Accessor interface {
-	NullCommon
+	Common
 	V() uint64
 	Set(value uint64)
 	Clone() Uint64Accessor

uint_test.go

@@ -49,7 +49,8 @@ func init() {
 	matrixSuite.SetConverters(uintReflectTypes, boolReflectTypes, uintBoolConverter)
 	// - to complex
 	uintComplexConverter := func(from interface{}, to reflect.Type, opts ...interface{}) (interface{}, bool) {
-		rv, c, s := reflect.ValueOf(from), complex128(0), false
+		var s bool
+		rv, c := reflect.ValueOf(from), complex128(0)
 		i := rv.Uint()
 		if s = isSafeUintToFloat(i, bitSizeMap[to.Kind()]); s {
 			c = complex(float64(i), 0)
@@ -65,7 +66,8 @@ func init() {
 	matrixSuite.SetConverters(uintReflectTypes, complexReflectTypes, uintComplexConverter)
 	// - to float
 	uintFloatConverter := func(from interface{}, to reflect.Type, opts ...interface{}) (interface{}, bool) {
-		rv, f, s := reflect.ValueOf(from), float64(0), false
+		var s bool
+		rv, f := reflect.ValueOf(from), float64(0)
 		i := rv.Uint()
 		if s = isSafeUintToFloat(i, bitSizeMap[to.Kind()]); s {
 			f = float64(i)