Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded routes #5

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Remove unneeded routes #5

merged 4 commits into from
Sep 30, 2020

Conversation

gustavoggsb
Copy link
Owner

@gustavoggsb gustavoggsb commented Sep 30, 2020 •
edited
Loading

Fixes #4

felipecrs
felipecrs requested changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@felipecrs felipecrs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a good PR title. The PR title must be very clear about its purpose. How about:

Remove unneeded routes

The Fixes #5 should be in the PR description.

products.http Outdated Show resolved Hide resolved
src/products/products.model.ts Outdated Show resolved Hide resolved
@gustavoggsb gustavoggsb changed the title Fixes #4 Remove unneeded routes Sep 30, 2020
@gustavoggsb gustavoggsb reopened this Sep 30, 2020
felipecrs
felipecrs requested changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@felipecrs felipecrs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing corrections from the previous review.

@gustavoggsb @felipecrs
Update products.http
ad1a332 
Co-authored-by: Felipe Santos <felipecassiors@gmail.com>
@gustavoggsb gustavoggsb merged commit 0d0d98d into master Sep 30, 2020
@gustavoggsb gustavoggsb deleted the develop branch September 30, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipecrs felipecrs felipecrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the routes names
2 participants
@gustavoggsb @felipecrs