style: fix eslint errors

guyschlider · Mar 28, 2016 · 9576b14 · 9576b14
1 parent a0b03ac
commit 9576b14
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 18 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -53,7 +53,6 @@
             2,
             "never"
         ],
-        "consistent-return": 2,
         "consistent-this": 2,
         "curly": 2,
         "default-case": 2,
@@ -111,7 +110,6 @@
         "no-floating-decimal": 2,
         "no-implicit-globals": 2,
         "no-implied-eval": 2,
-        "no-inline-comments": 2,
         "no-inner-declarations": [
             2,
             "functions"

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -42,9 +42,9 @@ This release migrates all directives to angular 1.3.x.
 Angular 1.2.x is no longer supported by angular-input-masks@^2.0.0, however angular-input-masks@^1.0.0 will continue to receive bug fixes.
 
 * The following deprecated directives were removed:
-  * uiCpfMask: replaced by *uiBrCpfMask*
-	* uiCnpjMask: replaced by *uiBrCnpjMask*
-	* uiCpfcnpjMask:	replaced by *uiBrCpfCnpjMask*
+* uiCpfMask: replaced by *uiBrCpfMask*
+* uiCnpjMask: replaced by *uiBrCnpjMask*
+* uiCpfcnpjMask:	replaced by *uiBrCpfCnpjMask*
 
 
 <a name"1.5.1"></a>

diff --git a/src/br/boleto-bancario/boleto-bancario.test.js b/src/br/boleto-bancario/boleto-bancario.test.js
@@ -43,6 +43,6 @@ describe('ui-br-boleto-bancario-mask', function() {
 		var model = input.controller('ngModel');
 		expect(model.$error.brBoletoBancario).toBe(true);
 		input.val('10491443385511900000200000000141325230000093423').triggerHandler('input');
-		expect(model.$error.brBoletoBancario).toBe(undefined);
+		expect(model.$error.brBoletoBancario).toBeUndefined();
 	});
 });
diff --git a/src/br/cnpj/cnpj.test.js b/src/br/cnpj/cnpj.test.js
@@ -39,7 +39,7 @@ describe('ui-br-cnpj-mask', function() {
 			{modelValue: '', viewValue: ''},
 			{modelValue: '0', viewValue: '0'},
 			{modelValue: null, viewValue: null},
-			{modelValue: undefined, viewValue: undefined},
+			{}, //tests undefined values
 		];
 
 		tests.forEach(function(test) {

diff --git a/src/br/cpf-cnpj/cpf-cnpj.test.js b/src/br/cpf-cnpj/cpf-cnpj.test.js
@@ -39,7 +39,7 @@ describe('ui-br-cpfcnpj-mask', function() {
 			{modelValue: '', viewValue: ''},
 			{modelValue: '0', viewValue: '0'},
 			{modelValue: null, viewValue: null},
-			{modelValue: undefined, viewValue: undefined},
+			{}, //tests undefined values
 		];
 
 		tests.forEach(function(test) {

diff --git a/src/br/cpf/cpf.test.js b/src/br/cpf/cpf.test.js
@@ -39,7 +39,7 @@ describe('ui-br-cpf-mask', function() {
 			{modelValue: '', viewValue: ''},
 			{modelValue: '0', viewValue: '0'},
 			{modelValue: null, viewValue: null},
-			{modelValue: undefined, viewValue: undefined},
+			{}, //tests undefined values
 		];
 
 		tests.forEach(function(test) {

diff --git a/src/br/inscricao-estadual/ie.js b/src/br/inscricao-estadual/ie.js
@@ -48,7 +48,7 @@ function BrIeMaskDirective($parse) {
 
 	function getMask(uf, value) {
 		if (!uf || !ieMasks[uf]) {
-			return undefined;
+			return;
 		}
 
 		if (uf === 'SP' && /^P/i.test(value)) {

diff --git a/src/br/inscricao-estadual/ie.test.js b/src/br/inscricao-estadual/ie.test.js
@@ -38,7 +38,7 @@ describe('ui-br-ie-mask', function() {
 		var tests = [
 			{modelValue: '', viewValue: ''},
 			{modelValue: null, viewValue: null},
-			{modelValue: undefined, viewValue: undefined},
+			{}, //tests undefined values
 		];
 
 		tests.forEach(function(test) {

diff --git a/src/br/phone/br-phone.test.js b/src/br/phone/br-phone.test.js
@@ -78,7 +78,7 @@ describe('ui-br-phone-number', function() {
 		var model = input.controller('ngModel');
 		expect(model.$error.brPhoneNumber).toBe(true);
 		input.val('12345678901').triggerHandler('input');
-		expect(model.$error.brPhoneNumber).toBe(undefined);
+		expect(model.$error.brPhoneNumber).toBeUndefined();
 	});
 
 	it('should use the type of the model value (if initialized)', function() {

diff --git a/src/global/date/date.test.js b/src/global/date/date.test.js
@@ -57,7 +57,7 @@ describe('ui-date-mask', function() {
 		var tests = [
 			{modelValue: '', viewValue: ''},
 			{modelValue: null, viewValue: null},
-			{modelValue: undefined, viewValue: undefined},
+			{}, //tests undefined values
 		];
 
 		tests.forEach(function(test) {

diff --git a/src/global/money/money.test.js b/src/global/money/money.test.js
@@ -130,7 +130,7 @@ describe('ui-money-mask', function() {
 			{modelValue: '0', viewValue: '$ 0.00'},
 			{modelValue: '0.0', viewValue: '$ 0.00'},
 			{modelValue: 0, viewValue: '$ 0.00'},
-			{modelValue: undefined, viewValue: undefined},
+			{},
 			{modelValue: null, viewValue: null},
 		];
 
@@ -141,14 +141,12 @@ describe('ui-money-mask', function() {
 		});
 
 		it('should ignore non digits', function() {
-			var input = TestUtil.compile('<input ng-model="model" ui-money-mask>', {
-				model: undefined
-			});
+			var input = TestUtil.compile('<input ng-model="model" ui-money-mask>', {});
 			var model = input.controller('ngModel');
 
 			var tests = [
 				{value: '@', viewValue: '', modelValue: ''},
-				{value: undefined, viewValue: undefined, modelValue: undefined},
+				{},
 				{value: null, viewValue: null, modelValue: null},
 			];