Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to application/octet-stream if we are unable to guess the content type for a multipart file upload #568

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Fallback to application/octet-stream if we are unable to guess the content type for a multipart file upload #568

merged 2 commits into from
Aug 3, 2023

Conversation

GrahamCampbell
Copy link
Member

Needs tests. Closes #567. Probably should be considered a feature and target 2.6.

TimWolla
TimWolla approved these changes Jul 31, 2023
View reviewed changes
Copy link

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me.

@GrahamCampbell GrahamCampbell changed the base branch from 2.5 to 2.6 August 3, 2023 14:55
@GrahamCampbell GrahamCampbell marked this pull request as ready for review August 3, 2023 14:59
@GrahamCampbell GrahamCampbell merged commit ed1315d into 2.6 Aug 3, 2023
38 checks passed
@GrahamCampbell GrahamCampbell deleted the multipart-content-fallback branch August 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content-Type assumption not done if the file don't have extension
2 participants
@GrahamCampbell @TimWolla