Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PEP 585 for collections.deque and collections.defaultdict #2

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Implement PEP 585 for collections.deque and collections.defaultdict #2

merged 1 commit into from
Jan 28, 2020

Conversation

ethanhs
Copy link

@ethanhs ethanhs commented Jan 28, 2020

These are (I think) the last two classes implemented in C that should be made generic.

gvanrossum
gvanrossum approved these changes Jan 28, 2020
View reviewed changes
Copy link
Owner

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gvanrossum gvanrossum merged commit 64c7d80 into gvanrossum:pep585 Jan 28, 2020
@ethanhs ethanhs mentioned this pull request Jan 29, 2020
Merged
gvanrossum pushed a commit that referenced this pull request Jan 30, 2020
@ethanhs @gvanrossum
Implement PEP 585 for collections.deque and ... (#2)
0af74d1 
... collections.defaultdict
gvanrossum pushed a commit that referenced this pull request Jul 14, 2020
@tiran
bpo-40955: Fix memory leak in subprocess module (pythonGH-20825)
0d3350d 
```
Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
    #1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/dev/python/cpython/Modules/_posixsubprocess.c:774
    #2 0xe0305b in cfunction_call Objects/methodobject.c:546
```

Signed-off-by: Christian Heimes <christian@python.org>
gvanrossum pushed a commit that referenced this pull request Jul 27, 2020
@miss-islington @tiran
bpo-40955: Fix memory leak in subprocess module (pythonGH-20825)
ee3f7fe 
```
Direct leak of 8 byte(s) in 1 object(s) allocated from:
    GH-0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
    GH-1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/dev/python/cpython/Modules/_posixsubprocess.c:774
    GH-2 0xe0305b in cfunction_call Objects/methodobject.c:546
```

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 0d3350d)

Co-authored-by: Christian Heimes <christian@python.org>
@iritkatriel iritkatriel mentioned this pull request Jul 10, 2021
Merged
gvanrossum pushed a commit that referenced this pull request Apr 20, 2022
@gpshead
pythongh-89455: Fix an uninitialized bool in exception print context. (…
861974b 
…python#91466)

Fix an uninitialized bool in exception print context.
    
`struct exception_print_context.need_close` was uninitialized.
    
Found by oss-fuzz in a test case running under the undefined behavior sanitizer.
    
https://oss-fuzz.com/testcase-detail/6217746058182656
    
```
Python/pythonrun.c:1241:28: runtime error: load of value 253, which is not a valid value for type 'bool'
    #0 0xbf2203 in print_chained cpython3/Python/pythonrun.c:1241:28
    #1 0xbea4bb in print_exception_cause_and_context cpython3/Python/pythonrun.c:1320:19
    #2 0xbea4bb in print_exception_recursive cpython3/Python/pythonrun.c:1470:13
    #3 0xbe9e39 in _PyErr_Display cpython3/Python/pythonrun.c:1517:9
```
    
Pretty obvious what the ommission was upon code inspection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanhs @gvanrossum