Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make isinstance and issubclass error for GenericAlias #6

Merged
merged 4 commits into from
Jan 31, 2020
Merged

Make isinstance and issubclass error for GenericAlias #6

merged 4 commits into from
Jan 31, 2020

Conversation

ethanhs
Copy link

@ethanhs ethanhs commented Jan 30, 2020

I wrote only basic tests, so if you want more let me know.

@ethanhs ethanhs mentioned this pull request Jan 30, 2020
Merged
gvanrossum
gvanrossum reviewed Jan 30, 2020
View reviewed changes
Copy link
Owner

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Łukasz is not convinced that we should do this, but I'm pushing back on it, so I think we should still do this in our branch. We can easily take it out if he convinces me.

Lib/test/test_genericalias.py Outdated Show resolved Hide resolved
Objects/descrobject.c Outdated Show resolved Hide resolved
@gvanrossum gvanrossum merged commit 6d3f535 into gvanrossum:pep585 Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanhs @gvanrossum