Add the code to generate the sky grid that will be used by pycbc_multi_inspiral #4485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is an example of the sky grid generated by |
|
Thanks! See some minor comments on formatting and CLI above, but this looks like a good start. |
…d let the output file extension be given
titodalcanton
changed the title
titodalcanton
changed the title
pannarale
approved these changes
Jan 25, 2024
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
…i_inspiral (gwastro#4485) * Add the code to generate the sky grid that will be used by pycbc_multi_inspiral * Minor changes on formatting and CLI * Change comments * Replace the explicit calculation of the norm with a numpy function and let the output file extension be given * Modify help messages * Remove non-used imports and write input values in the output file * Calculate the time delay corresponding to each sky point * Change the calculation of the angular spacing
lpathak97
pushed a commit
to lpathak97/pycbc
that referenced
this pull request
Mar 13, 2024
…i_inspiral (gwastro#4485) * Add the code to generate the sky grid that will be used by pycbc_multi_inspiral * Minor changes on formatting and CLI * Change comments * Replace the explicit calculation of the norm with a numpy function and let the output file extension be given * Modify help messages * Remove non-used imports and write input values in the output file * Calculate the time delay corresponding to each sky point * Change the calculation of the angular spacing
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
…i_inspiral (gwastro#4485) * Add the code to generate the sky grid that will be used by pycbc_multi_inspiral * Minor changes on formatting and CLI * Change comments * Replace the explicit calculation of the norm with a numpy function and let the output file extension be given * Modify help messages * Remove non-used imports and write input values in the output file * Calculate the time delay corresponding to each sky point * Change the calculation of the angular spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the code that generates the sky grid that will be used by
pycbc_multi_inspiral.The sky grid is circular and the points are placed following the method described in Section V of https://arxiv.org/abs/1410.6042.
The grid is first generated centered on the North pole, then rotated to the center of the localization error region. The output of the code is an hdf file with two datasets :
raanddec, corresponding to the sky pointspycbc_multi_inspiralwill loop over.