PyGRB postprocessing: segment writing/loading #4542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pannarale
requested changes
Nov 6, 2023
| seg_list.append(segments.segment(seg_starts[i], seg_ends[i])) | ||
|
|
||
| # Write segment_dict in proper format | ||
| # At the moment of this comment, there is only one segment |
There was a problem hiding this comment.
Can you try it with more than one segment?
There was a problem hiding this comment.
The segments in this context refer to the segments analyzed in pycbc_multi_inspiral. In the coh_ptf code the segments were defined in a more complicated way based on long time slides. We don't have that functionality for pycbc_multi_inspiral at this point, so the result of this function is a dictionary of one slide with the full analysis chunk (since it coalesces the smaller segments into one). Having multiple segments would imply a gap in the data in the current state of the code.
I suppose the functions here are mostly redundant if we're not doing long slides. This function is where the original code set up this structure. The output gets written into the XML file which the load_segment_dict function here was meant to read. I attempted to emulate this to achieve the same result.
Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com>
pannarale
approved these changes
Dec 7, 2023
maxtrevor
pushed a commit
to maxtrevor/pycbc
that referenced
this pull request
Dec 11, 2023
* Try fixing load_segment_dict * Use segments/GPS time API more correctly * Use h5py correctly * Codeclimate * Add comment * condense segment list creation Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com> * Plural start/end time in file output * Codeclimate --------- Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com>
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Dec 19, 2023
* Try fixing load_segment_dict * Use segments/GPS time API more correctly * Use h5py correctly * Codeclimate * Add comment * condense segment list creation Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com> * Plural start/end time in file output * Codeclimate --------- Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com>
GarethCabournDavies
pushed a commit
to GarethCabournDavies/pycbc
that referenced
this pull request
Dec 19, 2023
* Try fixing load_segment_dict * Use segments/GPS time API more correctly * Use h5py correctly * Codeclimate * Add comment * condense segment list creation Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com> * Plural start/end time in file output * Codeclimate --------- Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com>
maxtrevor
pushed a commit
to maxtrevor/pycbc
that referenced
this pull request
Jan 16, 2024
* Try fixing load_segment_dict * Use segments/GPS time API more correctly * Use h5py correctly * Codeclimate * Add comment * condense segment list creation Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com> * Plural start/end time in file output * Codeclimate --------- Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com>
bhooshan-gadre
pushed a commit
to bhooshan-gadre/pycbc
that referenced
this pull request
Mar 4, 2024
* Try fixing load_segment_dict * Use segments/GPS time API more correctly * Use h5py correctly * Codeclimate * Add comment * condense segment list creation Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com> * Plural start/end time in file output * Codeclimate --------- Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com>
lpathak97
pushed a commit
to lpathak97/pycbc
that referenced
this pull request
Mar 13, 2024
* Try fixing load_segment_dict * Use segments/GPS time API more correctly * Use h5py correctly * Codeclimate * Add comment * condense segment list creation Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com> * Plural start/end time in file output * Codeclimate --------- Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com>
acorreia61201
pushed a commit
to acorreia61201/pycbc
that referenced
this pull request
Apr 4, 2024
* Try fixing load_segment_dict * Use segments/GPS time API more correctly * Use h5py correctly * Codeclimate * Add comment * condense segment list creation Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com> * Plural start/end time in file output * Codeclimate --------- Co-authored-by: Francesco Pannarale <pannarale@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another step in completing #4419. The
load_segment_dictfunction returns the segments analyzed in the PyGRB analysis. The original code set up analysis segments differently for long time slides. Those have not been implemented (yet?) so here it is simpler. I had to add some writing of segments topycbc_multi_inspiralto get this to work.