Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source badge order #205

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Source badge order #205

merged 3 commits into from
Jan 25, 2022

Conversation

kkaris
Copy link
Contributor

@kkaris kkaris commented Jan 25, 2022

This PR changes the order of the statement row source badges. The dict of lists that determines the order of the badges is now set in api.py instead of in the jinja template.

Test by checking out the branch, running indra-db-service test-service and running a query that yields many badges and compare the ordering of the badges to the order in the source lists db_sources and reader_sources in indra/util/statement_presentation.py

@kkaris kkaris requested a review from bgyori January 25, 2022 16:57
bgyori
bgyori approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@bgyori bgyori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well, thanks!

@bgyori bgyori merged commit 454fe8f into gyorilab:master Jan 25, 2022
@kkaris kkaris deleted the source-order branch January 25, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgyori bgyori bgyori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kkaris @bgyori