Feature/simplification #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Daniel, Thanks for the enhancements! |
|
Hi, looks like you removed the logic that maps routes that are defined in the config file. Please see latest commit |
|
Yes, I removed them. I'm not sure if it is usefull, since there is another check of dynamic routes just below. |
|
not all routes are created dynamically. for example, the Collecting module uses routes that are defined in the config file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed various points on the module and simplified the configuration (automatic detection of the default page).
In the next days, I 'll publish a new version of Clean Url that is compatible with this module and can create full custom url with a root site, fixing omeka/omeka-s#870 and fixing #2 .