[ci] better errors on bad github response and fix too many status updates #8480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what was wrong, but CI was getting 422s from GitHub. Using a `raise_for_status=True` ClientSession circumvented gidgethubs native error handling logic smothering the HTTP response body where github places critical debugging information. Aiohttp is aware that `raise_for_status` provides no access to the response body. They addressed this in https://github.com/aio-libs/aiohttp/pulls/3892, but that has not been released because 4.0.0 has not yet been released. Another relevant issue: aio-libs/aiohttp#4600.
added 3 commits
April 6, 2020 18:24
danking
changed the title
|
Force merging due to ongoing disruption to CI. |
|
branch protection reenabled |
|
manually bumping all relevant PRs. |
|
(SHA change will enable more statuses) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was getting 422s from GitHub. Using a
raise_for_status=TrueClientSession circumvented gidgethubs nativeerror handling logic smothering the HTTP response body where github
places critical debugging information. Aiohttp is aware that
raise_for_statusprovides no access to the response body. They addressedthis in https://github.com/aio-libs/aiohttp/pulls/3892, but that has not
been released because 4.0.0 has not yet been released.
Moreover,
gidgethubincorrectly handles the too many statuses response. I'll PR a fix into their repo. For now, I've added a bit more information the logs and fixed the main issue, the missing['status'].Another relevant issue: aio-libs/aiohttp#4600.