Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss243 #305

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Iss243 #305

merged 2 commits into from
Dec 30, 2022

Conversation

Mikejmnez
Copy link
Collaborator

All tests pass. Pinning xgcm no longer necessary. Thus this PR closes #243

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good news! Please merge when the tests are complete.

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #305 (b664a76) into main (96f4493) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files           9        9           
  Lines        3928     3928           
  Branches      850      850           
=======================================
  Hits         3761     3761           
  Misses         97       97           
  Partials       70       70           
Flag Coverage Δ
unittests 95.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mikejmnez Mikejmnez merged commit 9c55efa into hainegroup:main Dec 30, 2022
@Mikejmnez Mikejmnez deleted the iss243 branch December 30, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pin xgcm < 0.7
2 participants