masking and dataset list #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikejmnez
requested review from
malmans2,
renskegelderloos,
ThomasHaine,
MaceKuailv and
asiddi24
as code owners
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
=======================================
Coverage 94.75% 94.75%
=======================================
Files 9 9
Lines 3944 3944
Branches 859 859
=======================================
Hits 3737 3737
Misses 131 131
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Apr 11, 2023
Closed
Mikejmnez
added a commit
to Mikejmnez/oceanspy
that referenced
this pull request
Apr 13, 2023
* compute masks * update dataset list, showing ECCO * add datasets * move order of datasets * . * restore all * restore all * compute when first masking * remove ECCO * include ECCO on dataset list * first perssit then compute * improved description of ECCO and daily ECCO --------- Co-authored-by: Miguel Jimenez <mjimen17@jhu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses issues #341 and #342 by:
mask.compute()explicitly .