For issue 321 and 269 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaceKuailv
requested review from
malmans2,
renskegelderloos,
ThomasHaine,
asiddi24 and
Mikejmnez
as code owners
… error message. I cannot recreate the error as well. So I redo the sampling part
|
There might be some test depends on the bug...I am a little reluctant to change the test. |
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 94.75% 94.74% -0.01%
==========================================
Files 9 9
Lines 3944 3940 -4
Branches 859 857 -2
==========================================
- Hits 3737 3733 -4
Misses 131 131
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced May 5, 2023
|
@MaceKuailv I would just delete code rather than commenting it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#321 In snap method, sometimes the coords got a false time dimension.
#269 Unpin matplotlib because cartopy update automatically solved the dependency bug.