Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new Station sampleMethod #377

Merged
merged 34 commits into from
Jul 6, 2023
Merged

new Station sampleMethod #377

merged 34 commits into from
Jul 6, 2023

Conversation

Mikejmnez
Copy link
Collaborator

this PR closes #369 #370 and #373

@Mikejmnez
Copy link
Collaborator Author

Hmm, I will take a look tomorrow or Monday..

@Mikejmnez
Copy link
Collaborator Author

Mikejmnez commented Jul 5, 2023

I figured it out. The two failing tests in this PR

ValueError: data must be finite, check for nan or inf values

are NOT associated with any of the station subsampling method regarding this PR. Instead, the ValueError happens in the mooring array testing, when incorporating ECCO data. The current failing tests in this PR used to pass, but began failing with a version release of scipy, particularly from 1.10 to 1.11 in June 25 this year.

I will describe the breaking changes on a separate issue, along with a general fix. For this current PR i will have to pin down scipy in order to proceed.

@Mikejmnez Mikejmnez temporarily deployed to pypi July 5, 2023 19:40 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #377 (8968694) into main (cea1845) will decrease coverage by 0.44%.
The diff coverage is 87.39%.

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   94.53%   94.10%   -0.44%     
==========================================
  Files           9        9              
  Lines        3971     4189     +218     
  Branches      943     1005      +62     
==========================================
+ Hits         3754     3942     +188     
- Misses        137      154      +17     
- Partials       80       93      +13     
Flag Coverage Δ
unittests 94.10% <87.39%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/subsample.py 92.62% <76.03%> (-3.88%) ⬇️
oceanspy/llc_rearrange.py 84.52% <98.91%> (+1.88%) ⬆️
oceanspy/plot.py 98.70% <100.00%> (+0.05%) ⬆️
oceanspy/utils.py 86.85% <100.00%> (-0.05%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool new features!

@Mikejmnez Mikejmnez merged commit c9ba7bc into hainegroup:main Jul 6, 2023
6 checks passed
@Mikejmnez Mikejmnez deleted the station branch July 6, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow compat of viewer_to_range with multiple "points" selected from poseidon_viewer
2 participants