Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing rise with jupyterlab-rise allows binder to get build #400

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

Mikejmnez
Copy link
Collaborator

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #400 (c6ca997) into main (df6c6ac) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   96.79%   96.79%           
=======================================
  Files           9        9           
  Lines        4987     4987           
  Branches     1189     1189           
=======================================
  Hits         4827     4827           
  Misses         90       90           
  Partials       70       70           
Flag Coverage Δ
unittests 96.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@MaceKuailv MaceKuailv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's simple and it works, so no complaint!

@MaceKuailv MaceKuailv merged commit 44b3d52 into hainegroup:main Nov 10, 2023
5 checks passed
@Mikejmnez Mikejmnez deleted the binder branch December 25, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binder fails to build environment
2 participants