Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake2 #423

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Intake2 #423

merged 2 commits into from
Mar 5, 2024

Conversation

Mikejmnez
Copy link
Collaborator

@Mikejmnez Mikejmnez commented Mar 4, 2024

New attempt to remove pin for intake. This PR:

  • Addresses and therefore closes issue pin intake < 2.0.0 ? #415 . Intake no longer needs to be pinned
  • Updates the location of oceanspy's test data in zenodo, as specified on the tests/conftest.py file
  • all tests pass on my local machine with an updated ospy_tests environment which include intake version 2.x

This PR makes #419 inconsequential and will be closing without merging.

It took me some time over the weekend, but I found that my mac was making hidden copies of files when taring the Data folder. These hidden ._ files were causing errors when reading and openining the xmitgcm_iters and xmitgcm_noiters datasets. ugh... all should be good now.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (c33d02b) to head (e4d9b47).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files           9        9           
  Lines        4987     4987           
  Branches     1190     1190           
=======================================
  Hits         4817     4817           
  Misses         97       97           
  Partials       73       73           
Flag Coverage Δ
unittests 96.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ThomasHaine ThomasHaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Well done sleuthing the hidden files!

@Mikejmnez Mikejmnez merged commit 3b4bab7 into hainegroup:main Mar 5, 2024
5 checks passed
@Mikejmnez Mikejmnez mentioned this pull request Mar 5, 2024
@Mikejmnez Mikejmnez deleted the intake2 branch April 1, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants