fix: Show deprecation warning regarding elm.json usage

halfzebra · Oct 9, 2018 · be8c7bf · be8c7bf
1 parent 2d907c8
commit be8c7bf
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/scripts/build.js b/scripts/build.js
@@ -23,6 +23,7 @@ const checkRequiredFiles = require('react-dev-utils/checkRequiredFiles');
 const formatWebpackMessages = require('react-dev-utils/formatWebpackMessages');
 const FileSizeReporter = require('react-dev-utils/FileSizeReporter');
 const formatElmCompilerErrors = require('./utils/formatElmCompilerErrors');
+const warn = require('./utils/warn');
 
 const measureFileSizesBeforeBuild =
   FileSizeReporter.measureFileSizesBeforeBuild;
@@ -72,6 +73,7 @@ measureFileSizesBeforeBuild(paths.appBuild)
       console.log('File sizes after gzip:\n');
       printFileSizesAfterBuild(stats, previousFileSizes, paths.appBuild);
       console.log();
+      warn(paths.elmJson);
     },
     err => {
       console.error(chalk.red('Failed to compile.\n'));
@@ -83,6 +85,7 @@ measureFileSizesBeforeBuild(paths.appBuild)
 // Create the production build and print the deployment instructions.
 function build(previousFileSizes) {
   const withDebugger = process.env.ELM_DEBUGGER === 'true' ? true : false;
+  console.log();
   if (withDebugger) {
     console.log(
       `Creating a ${process.env.NODE_ENV} build with debugger enabled...`

diff --git a/scripts/start.js b/scripts/start.js
@@ -31,6 +31,7 @@ const openBrowser = require('react-dev-utils/openBrowser');
 const createDevServerConfig = require('../config/webpackDevServer.config');
 const formatElmCompilerErrors = require('./utils/formatElmCompilerErrors');
 const paths = require('../config/paths');
+const warn = require('./utils/warn');
 
 if (fs.existsSync('elm.json') === false) {
   console.log('Please, run the build script from project root directory');
@@ -108,8 +109,10 @@ function createCompiler(webpack, config, appName, urls) {
     if (isSuccessful) {
       console.log(chalk.green('Compiled successfully!'));
     }
+
     if (isSuccessful && (isInteractive || isFirstCompile)) {
       printInstructions(appName, urls);
+      warn(paths.elmJson);
     }
     isFirstCompile = false;
 

diff --git a/scripts/utils/warn.js b/scripts/utils/warn.js
@@ -0,0 +1,15 @@
+const chalk = require('chalk');
+
+module.exports = function warn(elmJsonPath) {
+  const elmJson = require(elmJsonPath);
+  if (elmJson.homepage || elmJson.proxy) {
+    console.log();
+    console.log(chalk.yellow('Warning:'));
+    console.log();
+    console.log(
+      '  Using elm.json for configuring "homebage" and "proxy" is deprecated.'
+    );
+    console.log('  This feature will be removed in the future versions.');
+    console.log();
+  }
+};