Adds support for base64 and OAuth bearer tokens #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamnis
reviewed
May 25, 2023
hamnis
reviewed
May 25, 2023
| headers["Authorization"] = "Basic " + base64.b64encode(token.encode()).decode() | ||
| headers["Authorization"] = f"Basic {base64.b64encode(token.encode()).decode()}" | ||
| elif Utils.is_base64(self.password): | ||
| headers["Authorization"] = f"Basic {self.password}" |
There was a problem hiding this comment.
perhaps we should allow users to specify the Authorization header directly here.
Then we dont have to care about what users actually auths with.
There was a problem hiding this comment.
I don't think that there is a need. This works with basic auth and OAuth. If there is a need then we can add it.
But, I rather not add things that might be used.
hamnis
reviewed
May 25, 2023
|
@jimisola needs a format then I'll merge it |
Too many context changes today. Fixed it now. Thanks. |
hamnis
approved these changes
May 25, 2023
|
@jimisola released as 0.3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds support for:
I've also:
changed parsing library to argparse
added Utils class
removed all relative import (the try-import with sys.path.append in main.py is to allow the main.py to be run directly when developing)
Done regression tests (there is a unit test for non-auth download).
manually tested base64-encoded "username:password" tokens
NOTE: OAuth bearer token has not been tested because I have no easy way of testing it (Nexus does not support OAuth and I'm not aware of any GitLab och GitHub Maven repos to test with). My colleague has reviewed the code. A note in the changelog about the feature not being tested would be good.
Closes: #23