#1056 Fixed grammar for nested raw blocks #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.popState(); | ||
| return 'END_RAW_BLOCK'; | ||
| if (this.conditionStack[this.conditionStack.length-1] === 'raw') { |
There was a problem hiding this comment.
Should be using this.topState() here, but it currently returns the second top instead of the first top. Opened an issue about it at zaach/jison#291
There was a problem hiding this comment.
This comment should be a comment in the source.
|
Looks good, just want to get that comment in the source and then I'll be glad to merge. |
Closed
|
Cool. Just added the comment to the source. |
kpdecker
added a commit
that referenced
this pull request
Jul 20, 2015
#1056 Fixed grammar for nested raw blocks
|
Thanks! |
|
Thanks guys! |
|
Released in 4.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.