Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a configuration option context that can be used to pass data to custom functions #1400

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Add a configuration option context that can be used to pass data to custom functions #1400

merged 2 commits into from
Apr 3, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Apr 3, 2024

Context

This is an auxiliary PR following #1398

Related issues:

Fixes #1396

michaelbridge and others added 2 commits April 3, 2024 13:12
@michaelbridge @sequba
Add generic context option for custom function resolution (#1398)
16a774f 
* Add generic context option for custom function resolution

* Apply suggestions from code review

* Unknown type; add function test

* Update changelog

Co-authored-by: Kuba Sekowski <jakub.sekowski@handsontable.com>
@sequba
Merge branch 'develop' of github.com:handsontable/hyperformula into f…
4679586 
…eature/issue-1396
@sequba sequba self-assigned this Apr 3, 2024
@sequba sequba linked an issue Apr 3, 2024 that may be closed by this pull request
Per-instance internal custom state accessible from a custom function implementation #1396
Closed
@codecov Codecov
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.36%. Comparing base (a752b76) to head (4679586).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1400   +/-   ##
========================================
  Coverage    97.36%   97.36%           
========================================
  Files          169      169           
  Lines        14421    14422    +1     
  Branches      3100     3100           
========================================
+ Hits         14041    14042    +1     
  Misses         377      377           
  Partials         3        3
Files Coverage Δ
src/Config.ts 98.01% <100.00%> (+0.01%) ⬆️

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

Performance comparison of head (4679586) vs base (a752b76)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 548.49 | 547.28 | -0.22%
                                      Sheet B | 185.59 | 181.55 | -2.18%
                                      Sheet T | 159.83 | 156.15 | -2.30%
                                Column ranges | 572.12 | 562.95 | -1.60%
Sheet A:  change value, add/remove row/column |  15.11 |  16.46 | +8.93%
 Sheet B: change value, add/remove row/column | 144.78 |  144.2 | -0.40%
                   Column ranges - add column | 158.95 | 160.29 | +0.84%
                Column ranges - without batch | 455.14 | 467.81 | +2.78%
                        Column ranges - batch | 116.61 | 122.08 | +4.69%

@sequba sequba merged commit 2404ac4 into develop Apr 3, 2024
23 checks passed
@sequba sequba deleted the feature/issue-1396 branch April 3, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sequba sequba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Per-instance internal custom state accessible from a custom function implementation
2 participants
@sequba @michaelbridge