Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase height of the demos iframes #1403

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Apr 9, 2024

Context

  • Increasing the height of the iframes to show the full preview of a demo.

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

@sequba sequba merged commit 7061a47 into release/2.7.0 Apr 9, 2024
34 of 37 checks passed
@sequba sequba deleted the release/2.7.0-demos-size branch April 9, 2024 14:37
Copy link

github-actions bot commented Apr 9, 2024

Performance comparison of head (7f4c20a) vs base (31e3f61)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 555.07 | 536.25 | -3.39%
                                      Sheet B | 184.53 | 170.67 | -7.51%
                                      Sheet T | 158.86 | 152.32 | -4.12%
                                Column ranges | 566.37 | 552.18 | -2.51%
Sheet A:  change value, add/remove row/column |  15.71 |  14.41 | -8.27%
 Sheet B: change value, add/remove row/column | 152.99 | 139.99 | -8.50%
                   Column ranges - add column | 163.68 | 158.56 | -3.13%
                Column ranges - without batch |  483.2 | 472.48 | -2.22%
                        Column ranges - batch | 120.88 | 117.02 | -3.19%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant