This repository has been archived by the owner on Mar 14, 2022. It is now read-only.
Fixed #76 bug where id is repeating #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that as soon as our React developer is back from the vacation we'd be able to pull the changes. |
jansiegel
approved these changes
Jul 16, 2018
There was a problem hiding this comment.
I'll merge this as is, and apply the change described in this comment myself.
| @@ -67,7 +67,7 @@ export class HotTable extends React.Component { | |||
| * @returns {XML} | |||
| */ | |||
| render() { | |||
| this.id = this.props.id || 'hot' + new Date().getTime(); | |||
| this.id = this.props.id || 'hot' + Math.random().toString(36).substring(7); | |||
There was a problem hiding this comment.
@gavargas22 This seems like a good idea! Although, as in this case the random string would no longer be a number, it may produce ids like hotoykbhc, which makes the "hot" part less visible.
Do you think you could add a hyphen after "hot"? hot-oykbhc seems more readable to me than hotoykbhc.
There was a problem hiding this comment.
Sure, I think you are right!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.