fix: dispatch a beforeinput and input with `{inputType: 'insertLi…

…neBreak'}` when the enter key on the virtual keyboard is pressed

src/editor-mathfield/commands.ts

@@ -4,6 +4,7 @@ import { complete } from './autocomplete';
 import type { MathfieldPrivate } from './mathfield-private';
 import { onTypedText } from './keyboard-input';
 import { toggleKeystrokeCaption } from './keystroke-caption';
+import { contentDidChange, contentWillChange } from 'editor-model/listeners';
 
 registerCommand({
   undo: (mathfield: MathfieldPrivate) => {
@@ -71,12 +72,21 @@ registerCommand({
     return true;
   },
   commit: (mathfield: MathfieldPrivate) => {
-    mathfield.host?.dispatchEvent(
-      new Event('change', {
-        bubbles: true,
-        composed: true,
-      })
-    );
+    if (contentWillChange(mathfield.model, { inputType: 'insertLineBreak' })) {
+      // No matching keybinding: trigger a commit
+
+      if (mathfield.host) {
+        mathfield.host.dispatchEvent(
+          new Event('change', {
+            bubbles: true,
+            composed: true,
+          })
+        );
+      }
+
+      // Dispatch an 'input' event matching the behavior of `<textarea>`
+      contentDidChange(mathfield.model, { inputType: 'insertLineBreak' });
+    }
     return true;
   },
 });

src/editor/speech.ts

@@ -183,6 +183,10 @@ export function defaultSpeakHook(
 
   config ??= globalMathLive().config ?? {};
 
+  // Sigh... Not really necessary, but the version of the typescript
+  // compiler used by `grok` will complain about this
+  if (!config) return;
+
   if (!config.speechEngine || config.speechEngine === 'local') {
     // On ChromeOS: chrome.accessibilityFeatures.spokenFeedback
     // See also https://developer.chrome.com/apps/tts

test/smoke/index.html

@@ -201,6 +201,14 @@ <h2>MathML</h2>
         // },
       });
 
+      mf.addEventListener('input', (ev) => {
+        console.log('commit');
+      });
+
+      mf.addEventListener('beforeinput', (ev) => {
+        if (ev.inputType === 'insertLineBreak') console.log('enter');
+      });
+
       mf.addEventListener('input', (ev) => updateContent(mf));
 
       mf.addEventListener('selection-change', (ev) => {