Max safe integers

[shide1989]

Context

• node version: v8.6.0
• joi version: 10.6.0
• environment (node, browser): Node JS
• any other relevant information:

const schema = Joi.object().keys({ id: Joi.number() })
let id = 10107199254749992
console.log(id > Number.MAX_SAFE_INTEGER) // logs 'true'
parseInt(110107199254749992) == 110107199254749980 // = true, because the value is too high

when using an integer value > Number.MAX_SAFE_INTEGER, Joi simply parsed the value without warning.
This resulted in values being valid, when they're not

I think there should be a verification with Number.isSafeInteger(value) before parsing a number

[Marsup]

It's already done on the integer check.

[shide1989]

well it seems not to be working in our envirronment

[Marsup]

Have you called integer at least ? This won't work on floats obviously so it might still be a problem depending on your requirements but still a good remediation in the meantime.