Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

size filter does not respect Objects #385

Closed
takase1121 opened this issue Sep 11, 2021 · 2 comments
Closed

size filter does not respect Objects #385

takase1121 opened this issue Sep 11, 2021 · 2 comments

Comments

@takase1121
Copy link

takase1121 commented Sep 11, 2021

Based on the original ruby implementation, size should be able to get size of Objects.
.size works on both Hash and Array.

This is currently not the case here. .length doesn't work for Objects here.

Do we follow Ruby's "buggy" behavior or the "correct" behavior defined by the docs?

@harttle
Copy link
Owner

harttle commented Sep 11, 2021

Should be supported. Idealy same template should work in both Ruby and Node.js. We'll do it as long as we can.

@harttle harttle added the bug label Sep 11, 2021
@harttle harttle closed this as completed in 6c11426 Dec 7, 2021
github-actions bot pushed a commit that referenced this issue Dec 7, 2021
## [9.28.6](v9.28.5...v9.28.6) (2021-12-07)

### Bug Fixes

* size filter does not respect Objects, fixes [#385](#385) ([6c11426](6c11426))
* throws when using `preserveTimezones` on Node.js, fixes [#431](#431) ([e2ef236](e2ef236))
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

🎉 This issue has been resolved in version 9.28.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants