url_encode throws on undefined value

[pdehaan]

Probably an edge case, but somebody encountered this while migrating their blog from Jekyll to Eleventy (ref: 11ty/eleventy#2234 (comment)) and thought I'd verify if there is some option we're possibly not setting.

const {Liquid} = require("liquidjs");

const engine = new Liquid({
  strictVariables: false
});
const tpl = engine.parse('{{ v | url_encode }}');
engine.render(tpl, {v: undefined}).then(console.log);

// Error: Cannot read properties of undefined (reading 'split'), line:1, col:1

So basically this is calling {{ undefined | url_encode }} and throwing the following error:

"Error: Cannot read properties of undefined (reading 'split')"

(Although the error changes slightly depending on which filter you are calling.)

I'm not convinced whether or not this is something that is Liquid's responsibility (throwing errors when a filter tries to do something w/ a null or undefined value when it expects a string/whatever). I could easily be convinced either way, but just wanted to run it past you in case I'm missing some semi-obvious setting in the LiquidOptions class.

[harttle]

Regarding undefined variables, it's a bit confusing that errors are coming from two procedures

1. reading scope property. Whether or not throw depends on strictVariables
2. Executing filters and tags using these undefined variables. It's filter specific and Shopify liquid also have this behavior regardless strictVariables.

I guess what we can do is to align with the ruby version. If one filter in ruby tolerates undefined variable, liquidjs should also do the same.

[github-actions]

🎉 This issue has been resolved in version 9.35.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀