-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error When Accessing Subproperty of Bracketed Reference #643
Comments
Seems this works fine on shopify liquid. I'll treat this as a bug. BTW, I noticed another problem: |
Great, thanks for confirming! We have a workaround right now, but our workaround is a little ugly, so we'll be eagerly awaiting a fix. Let me know if there's anything more we can do to help with that. |
# [10.9.0](v10.8.4...v10.9.0) (2023-08-22) ### Bug Fixes * case should allow multiple values separated by or ([b8e7e2d](b8e7e2d)) * for throws undefined var with a null value with strictVariables ([dc6a301](dc6a301)) * remove_last was eating an extra character ([fc27313](fc27313)) ### Features * more flexible squared property read expression, fixes [#643](#643) ([#646](#646)) ([660d9be](660d9be))
🎉 This issue has been resolved in version 10.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Try the latest version. I created a test case for this scenario: liquidjs/test/e2e/issues.spec.ts Lines 457 to 466 in 942944e
|
This looks like it resolves our issue! Thank you for such a quick turnaround! |
I'm seeing what appears to be a parsing error when trying to access a subproperty of an object where the top-level key is wrapped in brackets. Here a minimal repro in the LiquidJS playground that demonstrates the error.
Template Value
{{ ["Key String with Spaces"].subproperty_key }}
Scope Object
Expected Result
Actual Result
The text was updated successfully, but these errors were encountered: