Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use UuidMixin for EventSession #398

Closed
jace opened this issue Jul 13, 2017 · 1 comment
Closed

Use UuidMixin for EventSession #398

jace opened this issue Jul 13, 2017 · 1 comment

Comments

@jace
Copy link
Member

jace commented Jul 13, 2017

As discussed in hasgeek/coaster#123, EventSession should replace its native UUID column with UuidMixin. A couple caveats though:

  1. EventSession's uuid column has nullable=True defined. This will need a migration.
  2. Nearly half the data has null values for session UUID despite a default value on the column. It's unclear why and needs investigation.
jace added a commit that referenced this issue Jul 13, 2017
Inserts random UUIDs into old sessions that didn’t have a UUID (a bug)
@jace jace closed this as completed in 297bb14 Jul 14, 2017
@jace
Copy link
Member Author

jace commented Jul 14, 2017

As far as I can tell, there's no bug (despite the claim in a3046b2). The uuid column was introduced after there were already 1.5 million sessions in production, and we simply didn't bother to generate UUIDs for them. All later sessions have UUIDs, and the code doesn't let that slip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant