Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some URLs are missing a character #625

Closed
asdofindia opened this issue Aug 18, 2021 · 1 comment · Fixed by hasgeek/baseframe#373
Closed

Some URLs are missing a character #625

asdofindia opened this issue Aug 18, 2021 · 1 comment · Fixed by hasgeek/baseframe#373

Comments

@asdofindia
Copy link

Eg:
image
https://hasjob.co/whitehatjr.com/7zgax - See the hitehatjr.com in the header

Similarly, https://hasjob.co/weqtechnologies.com/gnho9 has become eqtechnologies

I looked at the cleanurl function but that seems correct to me. Can't figure out who is off by one and why.

@jace
Copy link
Member

jace commented Aug 24, 2021

We rewrote the cleanurl filter to be a bit more robust, put it in the shared library, and goofed up on lstrip, which takes characters, not substrings. It was failing on URLs that begin with w, but the tests only had variations of example.com URLs. Fixed it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants