Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitter bot messes up hashtag for locations with spaces #88

Closed
rungta opened this issue Mar 27, 2014 · 3 comments
Closed

Twitter bot messes up hashtag for locations with spaces #88

rungta opened this issue Mar 27, 2014 · 3 comments

Comments

@rungta
Copy link

rungta commented Mar 27, 2014

Eg: Postings with a location value of New Delhi get tweeted with the #New hashtag instead of #NewDelhi. https://twitter.com/hasjob/status/449132000062881792
@rungta rungta changed the title Twitterbot messes up hashtag for locations with spaces Twitter bot messes up hashtag for locations with spaces Mar 27, 2014
@jace
Copy link
Member

jace commented Mar 27, 2014

The current code simply uses the first space-separated word token as the location name, making it suitable for locations like "Bangalore or Anywhere" or "Bangalore preferred". To do this properly, we need accurate location details (#55), for which pull request #82 is pending but doesn't appear good enough. I'll have to look at #55 separately to address this #88.

@jace
Copy link
Member

jace commented Oct 16, 2014

Since #55 is resolved, this should be trivial to implement now.

@jace
Copy link
Member

jace commented Oct 30, 2014

Fixed in 36e1a48.

@jace jace closed this as completed Oct 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jace @rungta