Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HIP-844 docs #543

Closed
SimiHunjan opened this issue Jan 19, 2024 · 1 comment
Closed

Add HIP-844 docs #543

SimiHunjan opened this issue Jan 19, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request p1 Highest priority smart contracts Features that involve smart contracts
Milestone

Comments

@SimiHunjan
Copy link
Collaborator

Problem

HIP: https://hips.hedera.com/hip/hip-844

Protobuf PR: hashgraph/hedera-protobufs#312

Introduce rules for when to update an Ethereum transaction signer’s nonce and a new field for externalising the nonce update in the record stream. This will help resolve issues where the Consensus nodes and the Mirror nodes are out of sync in regards to what the current value of an account’s nonce is.

message ContractFunctionResult {
    
    [...]

    /**
     * If not null this field specifies what the value of the signer account nonce is post transaction execution. 
     * For transactions that don't update the signer nonce (like HAPI ContractCall and ContractCreate transactions) this field should be null.
     */
    Int64Value signer_nonce = 15;
}

Solution

Update ContractFunctionResult section https://docs.hedera.com/hedera/sdks-and-apis/sdks/smart-contracts/call-a-smart-contract-function-1

Alternatives

No response

@SimiHunjan SimiHunjan added enhancement New feature or request smart contracts Features that involve smart contracts p1 Highest priority labels Jan 19, 2024
@SimiHunjan SimiHunjan added this to the Sprint 11 milestone Jan 19, 2024
@theekrystallee theekrystallee changed the title Add docs HIP-844 Add HIP-844 docs Jan 23, 2024
@theekrystallee theekrystallee added the documentation Improvements or additions to documentation label Jan 23, 2024
@SimiHunjan SimiHunjan modified the milestones: Sprint 11 , Sprint 12 Feb 5, 2024
@SimiHunjan SimiHunjan modified the milestones: Sprint 12, Sprint 13 Feb 16, 2024
@theekrystallee theekrystallee self-assigned this Feb 22, 2024
@theekrystallee theekrystallee modified the milestones: Sprint 13, Sprint 14 Mar 11, 2024
@theekrystallee
Copy link
Member

Resolved in ea8e999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request p1 Highest priority smart contracts Features that involve smart contracts
Projects
Status: Q2 2023
Status: Done
Development

No branches or pull requests

2 participants