Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-980: Add shadow fork support as a rejected idea #1058

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

IvanKavaldzhiev
Copy link
Contributor

Description:
After analyzing the efforts for implementing HIP-980, it was proposed to move the idea of shadow fork support in mirror-node as a rejected idea. That is, because it would have introduced too much REST API calls against public mirror node instances and would harm the performance. In addition, the UX would have included more efforts from a user perspective and wouldn't have been so easy to use.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
…al into hip-xxx-extend-apis-with-timestamp

# Conflicts:
#	HIP/hip-980.md

Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Signed-off-by: IvanKavaldzhiev <ivankavaldzhiev@gmail.com>
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit 0bd83bd
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/670666c2fd44610008e933a4
😎 Deploy Preview https://deploy-preview-1058--hedera-hips.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant