Create HIP: Adopt Cancun EVM SELFDESTRUCT semantics in Hedera #868

shemnon · 2024-01-24T21:26:34Z

Description:

HIP to adop the SELFDESTRUCT semantics added to the EVM as part of the Cancun fork.

Related issue(s):

Fixes #

Notes for reviewer:

This is one of four related HIPs covering Cancun support.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

HIP to adop the SELFDESTRUCT semantics added to the EVM as part of the Cancun fork. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

netlify · 2024-01-24T21:26:39Z

✅ Deploy Preview for hedera-hips ready!

Name	Link
🔨 Latest commit	`716e94e`
🔍 Latest deploy log	https://app.netlify.com/sites/hedera-hips/deploys/65d62b8cdcacba00085cfa9c
😎 Deploy Preview	https://deploy-preview-868--hedera-hips.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

Nana-EC

This is the more intricate of the Cancun features.
Left a few questions to inform some final consideration

Nana-EC · 2024-02-02T05:03:25Z

HIP/hip-868.md

+Hedera services may need to be changed to ensure that the transaction processing
+does not leave a "shadow" account number for transient self-destructs. Such
+transient self-destructs will also need to be tested to ensure all HTS tokens
+are properly swept during the sweep as well as the transient contract modes.


@q: Does Ethereum have support for cases where the SELFDESTRUCT attempt fail for some reason and funds aren't swept?
We may want to support cases where the beneficiary account isn't associated with the HTS token

No. Selfdestruct always happens. The only way it doesn't stick is if the outer calling contract reverts. Then all sub-calls side effects are fully reverted.

This HIP should specify what happens, then, in this case where the beneficiary account doesn't have an association to the HTS token? Allowing the sweep to happen in that case breaks our rules for tokens (and seems to allow for exploits), but if not doing it then what?

What about for

Sweep (choose 1)

Revert the overall transaction if the transfer account is not associated with the token. This stays in line with Hedera architecture since HTS tokens is an outside EVM

Best effort to transfer tokens to transfer account. If it's not associated the transaction does fail since the HBAR is swept. I'm leaning to this option since Sweep on the EVM doesn't factor in token balances anyway

Delete (intention with fallback logic)

transfer tokens to the transfer account noted in the selfdestruct

If transfer account is not associated transfer tokens to the treasurer as the last option.

Wdyt?

Nana-EC · 2024-02-02T05:08:14Z

HIP/hip-868.md

+
+### Hedera Services
+
+Hedera services may need to be changed to ensure that the transaction processing


Q: Does the EVM assign an address to the contract that did not exist prior to transaction processing or does it go unaddressed?

Another question is should that contract call another contract or send cryptocurrency.
What address does the EVM/Ethereum use to express the from address in that account to account interaction?
This may inform how we identify the transient contract

You know the address of the contract during the initcode, so yes. The case it matters for 6780 would be CREATE2 initcode, where the address is a function within the EVM of the salt and initcode. We are safe not allocating a hedera address until after the full transaction completes (until the hedera account service precompile launches...)

The other case is contract creation transaction. That already has a high overhead cost to users.

The problem is if we don't create an account then the record file will have an ambiguous contractId as the recipient of any transfers as part of the sweep.

If we can get a unique address that will never be reused then we should issue an contractId with the record files showing ContractCreate, Contract Delete child transactions

david-bakin-sl

Left some questions.

david-bakin-sl · 2024-02-05T18:06:59Z

HIP/hip-868.md

+Hedera services may need to be changed to ensure that the transaction processing
+does not leave a "shadow" account number for transient self-destructs. Such
+transient self-destructs will also need to be tested to ensure all HTS tokens
+are properly swept during the sweep as well as the transient contract modes.


This HIP should specify what happens, then, in this case where the beneficiary account doesn't have an association to the HTS token? Allowing the sweep to happen in that case breaks our rules for tokens (and seems to allow for exploits), but if not doing it then what?

david-bakin-sl · 2024-02-05T18:07:43Z

HIP/hip-868.md

+deprecated for at least a year on Ethereum Mainnet, so it is expected that such
+use cases have never found their way onto Hedera's Mainnet.


Is it worth looking at mirror node data to see if in fact it has happened on mainnet? (Or confirm it hasn't, as expected.)

Yes, let's check

david-bakin-sl · 2024-02-05T18:13:24Z

HIP/hip-868.md

+The substantial changes of this HIP are the removal of some functionality in
+some circumstances. There are no known security impacts of this removal and
+furthermore there are no known security mitigations that require the presence of
+the removed functionality. It is expected the security implications will be


"minimal to none" -> why not just "none" then?

(Although I see that EIP-6780 says something more specific anyway - does it need to be repeated here?

)

stoqnkpL · 2024-02-06T11:45:41Z

HIP/hip-868.md

+However, since Hedera places "ownership" of token balances with the account
+holding the balance we will need to extend the behavior of the sweep mode to
+also transfer all HTS tokens to the beneficiary. Notably, for a successful
+transaction beneficiary accounts must support the receiving of HTS tokens via
+association configuration. This is consistent with current self-destruct
+behavior and consistent with the spirit of the Ethereum change in that code and
+the account are no longer deleted.


Currently, if the contract holds HTS token balance the self-destruct fails with TRANSACTION_REQUIRES_ZERO_TOKEN_BALANCES. This specification is changing the current behavior.

Nana-EC

In follow up seems we'll

keep it simple and focus on EVM changes only here
utilize pre-existing flow to govern HTS balances and transient address/account considerations

Clarify that there will be EVM non-equivalence - which already exists - for self destructs that interact with Hedera semantics in a way that is affected by the security model. Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com>

shemnon · 2024-02-20T22:10:05Z

David's changes LGTM

HIP/hip-868.md

IvanKavaldzhiev

LGTM

mgarbs · 2024-02-21T14:18:06Z

HIP/hip-868.md

+title: Support Cancun Self-Destruct Semantics in Smart Contract Services
+author: Danno Ferrin (@shemnon)
+working-group: Nana Essilfie-Conduah <@nana-ec>, Jasper Potts <@jasperpotts>, Richard Bair <@rbair23>, Stoyan Panayotov <stoyan.panayotov@limechain.tech>
+type: Standards Track


We added a new header for council members to see who requested hips. Could you add the 'requested-by' header here and add whoever requested this hip?

This is part of EVM equivalence and ensuring the network continues to support the latest Ethereum Hardfork features.
There's no one or few requestors. Just the network staying up to date to ensure support.

Maybe "EVM developers" in general?

Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>

…aph#868) Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com> Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com> Co-authored-by: David S Bakin <117694041+david-bakin-sl@users.noreply.github.com> Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Co-authored-by: Michael Garber <michael.garber@swirldslabs.com> Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>

Adopt Cancun EVM SELFDESTRUCT semantics in Hedera

13b2ac7

HIP to adop the SELFDESTRUCT semantics added to the EVM as part of the Cancun fork. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

shemnon changed the title ~~Adopt Cancun EVM SELFDESTRUCT semantics in Hedera~~ Create HIP: Adopt Cancun EVM SELFDESTRUCT semantics in Hedera Jan 24, 2024

shemnon mentioned this pull request Jan 24, 2024

Cancun Support HIPs #856

Closed

2 tasks

Nana-EC mentioned this pull request Jan 30, 2024

Design: Self-destructs with non-existing beneficiary should create a hollow account hashgraph/hedera-services#10553

Open

Front matter

ae09dc4

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>

mgarbs requested review from rbair23, nickpoorman, jasperpotts, Nana-EC, lukelee-sl and david-bakin-sl February 1, 2024 20:30

Nana-EC requested changes Feb 2, 2024

View reviewed changes

david-bakin-sl reviewed Feb 5, 2024

View reviewed changes

stoqnkpL reviewed Feb 6, 2024

View reviewed changes

Nana-EC reviewed Feb 13, 2024

View reviewed changes

david-bakin-sl force-pushed the cancun-selfdestruct-changes branch from 92c3ce1 to ae09dc4 Compare February 20, 2024 18:01

Nana-EC previously approved these changes Feb 21, 2024

View reviewed changes

HIP/hip-868.md Outdated Show resolved Hide resolved

stoqnkpL approved these changes Feb 21, 2024

View reviewed changes

IvanKavaldzhiev approved these changes Feb 21, 2024

View reviewed changes

mgarbs reviewed Feb 21, 2024

View reviewed changes

shemnon dismissed Nana-EC’s stale review via c90200d February 21, 2024 14:58

shemnon and others added 3 commits February 21, 2024 08:58

Update HIP/hip-868.md

c90200d

Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>

Update hip-868.md to Review

9bcc4a4

Update hip-868.md to Last Call

716e94e

mgarbs approved these changes Feb 21, 2024

View reviewed changes

mgarbs merged commit 20a21f2 into hashgraph:main Feb 21, 2024
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create HIP: Adopt Cancun EVM SELFDESTRUCT semantics in Hedera #868

Create HIP: Adopt Cancun EVM SELFDESTRUCT semantics in Hedera #868

shemnon commented Jan 24, 2024

netlify bot commented Jan 24, 2024 •

edited

Loading

Nana-EC left a comment

Nana-EC Feb 2, 2024

shemnon Feb 2, 2024

david-bakin-sl Feb 5, 2024

Nana-EC Feb 10, 2024

Nana-EC Feb 2, 2024

Nana-EC Feb 2, 2024

shemnon Feb 2, 2024

Nana-EC Feb 10, 2024

david-bakin-sl left a comment

david-bakin-sl Feb 5, 2024

david-bakin-sl Feb 5, 2024

Nana-EC Feb 10, 2024

david-bakin-sl Feb 5, 2024

stoqnkpL Feb 6, 2024

Nana-EC left a comment

shemnon commented Feb 20, 2024

IvanKavaldzhiev left a comment

mgarbs Feb 21, 2024

Nana-EC Feb 21, 2024 •

edited

Loading


		### Hedera Services

		Hedera services may need to be changed to ensure that the transaction processing

		deprecated for at least a year on Ethereum Mainnet, so it is expected that such
		use cases have never found their way onto Hedera's Mainnet.

Create HIP: Adopt Cancun EVM SELFDESTRUCT semantics in Hedera #868

Create HIP: Adopt Cancun EVM SELFDESTRUCT semantics in Hedera #868

Conversation

shemnon commented Jan 24, 2024

netlify bot commented Jan 24, 2024 • edited Loading

✅ Deploy Preview for hedera-hips ready!

Nana-EC left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

david-bakin-sl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

shemnon commented Feb 20, 2024

IvanKavaldzhiev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nana-EC Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

netlify bot commented Jan 24, 2024 •

edited

Loading

Nana-EC Feb 21, 2024 •

edited

Loading