-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e tests for hbar/token allowance #1682
Add e2e tests for hbar/token allowance #1682
Conversation
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1682 +/- ##
=======================================
Coverage 77.48% 77.48%
=======================================
Files 26 26
Lines 2323 2323
Branches 475 475
=======================================
Hits 1800 1800
Misses 379 379
Partials 144 144
☔ View full report in Codecov by Sentry. |
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@natanasow should we split this PR in 2? so we can move forward with the fix of #1672 ? |
Yep, yesterday I found a bug in the latest mirror node image and this PR will be blocked for a while. Will open a separate PR only for #1672 fix 🚀. |
@natanasow you should rebase. I think Eric address the other items so it should just be the pnpm part |
Signed-off-by: nikolay <n.atanasow94@gmail.com>
2d10155
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
The |
Description:
There was a test but was commented on because the image with the fix wasn't ready. HBAR approval could be done only via hapi but we don't test hapi calls in acceptance tests, so no actions are needed.
PS: charts install fails due to removing pnpm from dockerfile, so it has to be added in packages/server as a dependency
Related issue(s):
Fixes #1681
Blocked by:
Notes for reviewer:
Checklist