Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for hbar/token allowance #1682

Closed

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Aug 25, 2023

Description:

There was a test but was commented on because the image with the fix wasn't ready. HBAR approval could be done only via hapi but we don't test hapi calls in acceptance tests, so no actions are needed.

PS: charts install fails due to removing pnpm from dockerfile, so it has to be added in packages/server as a dependency

Related issue(s):

Fixes #1681

Blocked by:

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow self-assigned this Aug 25, 2023
@natanasow natanasow added enhancement New feature or request limechain labels Aug 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (24b48c4) 77.48% compared to head (b27c7ac) 77.48%.

❗ Current head b27c7ac differs from pull request most recent head a27c5bd. Consider uploading reports for the commit a27c5bd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1682   +/-   ##
=======================================
  Coverage   77.48%   77.48%           
=======================================
  Files          26       26           
  Lines        2323     2323           
  Branches      475      475           
=======================================
  Hits         1800     1800           
  Misses        379      379           
  Partials      144      144           
Files Changed Coverage Δ
packages/relay/src/lib/clients/cache/redisCache.ts 55.88% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow marked this pull request as draft August 25, 2023 14:13
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow requested a review from isavov August 25, 2023 15:30
isavov
isavov previously approved these changes Aug 25, 2023
@natanasow natanasow marked this pull request as ready for review August 25, 2023 15:39
AlfredoG87
AlfredoG87 previously approved these changes Aug 25, 2023
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nana-EC
Nana-EC previously approved these changes Aug 25, 2023
@AlfredoG87
Copy link
Collaborator

@natanasow should we split this PR in 2? so we can move forward with the fix of #1672 ?

@natanasow
Copy link
Collaborator Author

@natanasow should we split this PR in 2? so we can move forward with the fix of #1672 ?

Yep, yesterday I found a bug in the latest mirror node image and this PR will be blocked for a while. Will open a separate PR only for #1672 fix 🚀.

@ebadiere ebadiere added this to the 0.32.0 milestone Sep 6, 2023
@Nana-EC
Copy link
Collaborator

Nana-EC commented Sep 8, 2023

@natanasow you should rebase. I think Eric address the other items so it should just be the pnpm part

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow dismissed stale reviews from Nana-EC, AlfredoG87, and isavov via 2d10155 September 11, 2023 04:44
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@natanasow
Copy link
Collaborator Author

@natanasow you should rebase. I think Eric address the other items so it should just be the pnpm part

The pnpm had been already added in another PR I guess, so this PR could be closed because it doesn't change anything right now 😕 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add additional E2E tests for HBAR/Token allowances.
7 participants