Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TheGraph environment variables recommended values for HashIO Relay #1744

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

AlfredoG87
Copy link
Collaborator

Description:
Overrides some GraphNode env configurations to optimize for HashIO Hedera JSON RPC Relay.

Related issue(s):

Fixes #700

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 self-assigned this Sep 15, 2023
@AlfredoG87 AlfredoG87 added enhancement New feature or request P2 labels Sep 15, 2023
@AlfredoG87 AlfredoG87 added this to the 0.32.0 milestone Sep 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4c8d39d) 76.87% compared to head (9675b98) 76.87%.
Report is 1 commits behind head on main.

❗ Current head 9675b98 differs from pull request most recent head 8dc6eed. Consider uploading reports for the commit 8dc6eed to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1744   +/-   ##
=======================================
  Coverage   76.87%   76.87%           
=======================================
  Files          39       39           
  Lines        2919     2919           
  Branches      587      587           
=======================================
  Hits         2244     2244           
  Misses        496      496           
  Partials      179      179           
Files Changed Coverage Δ
packages/relay/src/lib/clients/mirrorNodeClient.ts 89.02% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
@AlfredoG87 AlfredoG87 force-pushed the 700-thegraph-env-variables-optimization branch from 842a401 to f565689 Compare September 18, 2023 23:38
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
…t way it works better

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlfredoG87 AlfredoG87 marked this pull request as ready for review September 18, 2023 23:57
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@AlfredoG87 AlfredoG87 merged commit 7d8abd8 into main Sep 19, 2023
26 checks passed
@AlfredoG87 AlfredoG87 deleted the 700-thegraph-env-variables-optimization branch September 19, 2023 15:26
ebadiere pushed a commit that referenced this pull request Sep 20, 2023
…1744)

* TheGraph node environment variables recommended values for HashIO Relay

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

* ETHEREUM_REORG_THRESHOLD to 0

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

* update doc so ETHEREUM_POLLING_INTERVAL is without ms and to 1000 that way it works better

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

---------

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
ebadiere pushed a commit that referenced this pull request Sep 20, 2023
…1744)

* TheGraph node environment variables recommended values for HashIO Relay

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

* ETHEREUM_REORG_THRESHOLD to 0

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

* update doc so ETHEREUM_POLLING_INTERVAL is without ms and to 1000 that way it works better

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

---------

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
mshakeg pushed a commit to mshakeg/hedera-json-rpc-relay that referenced this pull request Oct 18, 2023
…ashgraph#1744)

* TheGraph node environment variables recommended values for HashIO Relay

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

* ETHEREUM_REORG_THRESHOLD to 0

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

* update doc so ETHEREUM_POLLING_INTERVAL is without ms and to 1000 that way it works better

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>

---------

Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List all graph node env variables for hedera
3 participants