Reduce Accepted Error codes from MirrorNodeClient.ts
#1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of the actual error Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
AlfredoG87
changed the title
AlfredoG87
changed the title
MirrorNodeClient.ts
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
AlfredoG87
requested review from
ebadiere,
lukelee-sl and
a team
as code owners
Nana-EC
approved these changes
Sep 16, 2023
ebadiere
pushed a commit
that referenced
this pull request
Sep 18, 2023
* removing anything that is not 404, only 404 should default to null instead of the actual error Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> * fixed broken unit tests Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> --------- Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
pushed a commit
that referenced
this pull request
Sep 20, 2023
* removing anything that is not 404, only 404 should default to null instead of the actual error Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> * fixed broken unit tests Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> --------- Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
mshakeg
pushed a commit
to mshakeg/hedera-json-rpc-relay
that referenced
this pull request
Oct 18, 2023
* removing anything that is not 404, only 404 should default to null instead of the actual error Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> * fixed broken unit tests Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> --------- Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently the MirrorNodeClient.ts has a collection of Endpoints and its corresponding
acceptederror codes.That instead of throwing an exception with the actual error, it will handle it and return
nullThe only scenario where is justified to return
nullinstead of throwing the error is for404exceptions, otherwise the clients should handle the error appropriately.Related issue(s):
Fixes #1276
Notes for reviewer:
Checklist