test: stabilize acceptance tests and update local-node #2255

georgi-l95 · 2024-03-28T07:03:57Z

Description:
This PR aims to update local node version to latest and utilize the modulirezed codebase version of the network node, as well as refactor most of the acceptance tests, because now network node is more heavy and this makes the tests flaky. SDKs are timing out, probably due to not enough resources.

Remove unused and re-arange all used imports according to JS conventions.
Changes to before logic of the index.spec.ts:

Creates on Inital Account using the SDK, which will be responsible for creating other accounts.

Changes to before logic of the index.spec.ts:

Adds logic to refund all HBars back from all created accounts back to operator, to minimize expenses and provide more correct spent amount.

Rework before of most of the tests to add optimizations, rely less on SDKs and more on the relay itself.
Modifies eth_sendRawTransaction to retry on certain errors, like Timeout or connection dropped. Retyring triggers the flow of creating new instance of the SDK Client, which should mitigate the issues we face with the new local-node versions and more specifically when Client is configured to point against only one node.
Updates SDK and Local-node version to latests.

Positives:

Faster tests, because we don't used so ofter the SDKs and that means that we don't need to explicitly wait for changes to be propagated to mirror node. Some tests are more than a minute faster.
We rely more on the relay itself, which is the object of our tests here.

Related issue(s):

Fixes #2309
Fixes #2341

Notes for reviewer:
This will not fix the issues with the SDK itself and how we handle timeout. This will be done in the next PR to avoid many changes at once. Main aim here is to update to the latest modularization code base and make use of the tests.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

github-actions · 2024-03-28T07:08:36Z

Tests

    2 files 147 suites 13s ⏱️
815 tests 814 ✔️ 1 💤 0 ❌
827 runs 826 ✔️ 1 💤 0 ❌

Results for commit 82f9370.

♻️ This comment has been updated with latest results.

codecov-commenter · 2024-03-28T07:09:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.15%. Comparing base (f5d8a48) to head (619406e).
Report is 18 commits behind head on main.

❗ Current head 619406e differs from pull request most recent head 3c26881. Consider uploading reports for the commit 3c26881 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2255   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files          13       13           
  Lines         644      644           
  Branches      118      118           
=======================================
  Hits          484      484           
  Misses        115      115           
  Partials       45       45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-03-28T07:16:24Z

Acceptance Tests

    24 files   581 suites 33m 30s ⏱️
  583 tests   571 ✔️   3 💤   9 ❌
2 339 runs 2 305 ✔️ 15 💤 19 ❌

Results for commit 82f9370.

♻️ This comment has been updated with latest results.

AlfredoG87

LGTM

packages/server/src/koaJsonRpc/index.ts

Nana-EC

Good effort on stabilization.
Left some comments on 1st pass

packages/relay/src/lib/errors/SDKClientError.ts

Nana-EC · 2024-04-22T20:27:51Z

packages/relay/src/lib/eth.ts

-      const contractExecuteResponse = await this.hapiService
-        .getSDKClient()
-        .submitEthereumTransaction(transactionBuffer, EthImpl.ethSendRawTransaction, requestIdPrefix);
+      const contractExecuteResponse = await this.sendRawTransactionWithRetry(


Q: Why are we retrying for sendRawTransaction vs leaving it on user client logic?
The challenge is here is there's balance implication to both the sender and the host.

Nana-EC · 2024-04-22T20:31:04Z

packages/relay/src/lib/services/hapiService/hapiService.ts

@@ -101,7 +101,7 @@ export default class HAPIService {
    const currentDateNow = Date.now();
    this.initialTransactionCount = parseInt(process.env.HAPI_CLIENT_TRANSACTION_RESET!) || 0;
    this.initialResetDuration = parseInt(process.env.HAPI_CLIENT_DURATION_RESET!) || 0;
-    this.initialErrorCodes = JSON.parse(process.env.HAPI_CLIENT_ERROR_RESET || '[50]');
+    this.initialErrorCodes = JSON.parse(process.env.HAPI_CLIENT_ERROR_RESET || '[21, 50]');


Q:50 is INVALID_TRANSACTION_BODY and 21 is UNKNOWN
We should document these somewhere. Likely in configs README

Added to configuration.md

Nana-EC · 2024-04-22T20:33:07Z

packages/server/tests/acceptance/htsPrecompile/tokenManagement.spec.ts


  this.beforeAll(async () => {
    requestId = Utils.generateRequestId();
+    const initialAccount: AliasAccount = global.accounts[0];
+    const initialAmount: string = '5000000000'; //50 Hbar


We should make this configureable

Nana-EC · 2024-04-22T20:33:26Z

packages/server/tests/acceptance/htsPrecompile_v1.spec.ts

-    const contractDeployer = await servicesNode.createAliasAccount(50, relay.provider, requestId);
-    BaseHTSContractAddress = await deployBaseHTSContract(contractDeployer.wallet);
+    const initialAccount: AliasAccount = global.accounts[0];
+    const initialAmount: string = '5000000000'; //50 Hbar


make configureable

Nana-EC · 2024-04-22T20:34:27Z

packages/server/tests/acceptance/index.spec.ts

+
+    global.accounts = new Array<AliasAccount>(initialAccount);
+    // wait 3 seconds to propagate to mirror node all needed changes.
+    await new Promise((r) => setTimeout(r, 3000));


Q: Why wait instead of poll.
Waiting can be problematic and hides failure reasons

Yep, you're right. Changed.

quiet-node

Absolute wonderful work! Thanks a lot! I left comments and questions around!

packages/server/tests/acceptance/htsPrecompile/tokenManagement.spec.ts

packages/server/tests/acceptance/rateLimiter.spec.ts

packages/server/tests/acceptance/rpc_batch1.spec.ts

packages/server/tests/acceptance/rpc_batch2.spec.ts

packages/server/tests/clients/servicesClient.ts

packages/server/tests/helpers/utils.ts

packages/ws-server/tests/acceptance/call.spec.ts

Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: update local node Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: set verbose to trace Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: bump service tag Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: add extra debug steps Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> chore: fix debug test Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> chore: fix debugging Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> chore: fix debugging Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> chore:test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: testing Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> chore: revert reset counts Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> fix: vlaue fiddle Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> add env logging Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> bump timeout Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> switch to full node Signed-off-by: Iliya Savov <isavov@users.noreply.github.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert unnecessery changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 1 Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 1 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 2 Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 2 Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix tests Signed-off-by: georgi-l95 <glazarov95@gmail.com> remove only Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimize rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimization Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimize Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimizaitons Signed-off-by: georgi-l95 <glazarov95@gmail.com> more optimizations and code smells Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimization Signed-off-by: georgi-l95 <glazarov95@gmail.com> adds JSDocs Signed-off-by: georgi-l95 <glazarov95@gmail.com> last optimizations to rpc_batch1 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rateLimiter.spec.ts Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimize htsPrecompile_v1.spec.ts Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimize precompileCalls Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix precompileCall Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimize rpc_batch2 Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimize rpc_batch2 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc_batch 2 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix precompileCalls Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 2 Signed-off-by: georgi-l95 <glazarov95@gmail.com> disable batch Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc_batch 2 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc_batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 2 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc_batch 2 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 2 and 3 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rate limiter Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert changes to retry script Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix tokenCreate Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: update local node Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: update sdk Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> rework ws acceptance tests Signed-off-by: georgi-l95 <glazarov95@gmail.com> add logger Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> adjust websocket values Signed-off-by: georgi-l95 <glazarov95@gmail.com> address comments Signed-off-by: georgi-l95 <glazarov95@gmail.com> optimization Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix websocket tests Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix websocket tests Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix precompilecalls Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: add missing type Signed-off-by: georgi-l95 <glazarov95@gmail.com> apply more clear logic to condition Signed-off-by: georgi-l95 <glazarov95@gmail.com>

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

sonarcloud · 2024-04-23T17:03:49Z

Quality Gate failed

Failed conditions
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

quiet-node

LGTM. Great work!

georgi-l95 requested review from Ivo-Yankov, a team, AlfredoG87, ebadiere and Nana-EC as code owners March 28, 2024 07:03

georgi-l95 self-assigned this Mar 28, 2024

Nana-EC previously approved these changes Mar 28, 2024

View reviewed changes

AlfredoG87 previously approved these changes Apr 2, 2024

View reviewed changes

georgi-l95 dismissed stale reviews from AlfredoG87 and Nana-EC via a040e9f April 3, 2024 11:14

georgi-l95 force-pushed the bump-local-node-version branch from a040e9f to 6411c43 Compare April 3, 2024 11:15

AlfredoG87 previously approved these changes Apr 3, 2024

View reviewed changes

georgi-l95 dismissed AlfredoG87’s stale review via 9102ac8 April 4, 2024 08:39

georgi-l95 marked this pull request as draft April 4, 2024 16:57

georgi-l95 linked an issue Apr 10, 2024 that may be closed by this pull request

Stabilize acceptance tests and update local node #2309

Closed

georgi-l95 force-pushed the bump-local-node-version branch 3 times, most recently from f57c043 to 7831882 Compare April 12, 2024 07:37

georgi-l95 changed the title ~~chore: update local node version~~ test: stabilize acceptance tests and update local-node Apr 12, 2024

georgi-l95 force-pushed the bump-local-node-version branch 2 times, most recently from aa65ea2 to e2783fa Compare April 16, 2024 14:35

georgi-l95 marked this pull request as ready for review April 17, 2024 07:47

georgi-l95 requested a review from lukelee-sl as a code owner April 17, 2024 07:47

Ivo-Yankov reviewed Apr 17, 2024

View reviewed changes

packages/server/src/koaJsonRpc/index.ts Outdated Show resolved Hide resolved

georgi-l95 requested review from natanasow, konstantinabl and victor-yanev April 17, 2024 08:27

Nana-EC reviewed Apr 22, 2024

View reviewed changes

quiet-node reviewed Apr 22, 2024

View reviewed changes

quiet-node mentioned this pull request Apr 22, 2024

test: broke total acceptancetest in ws-server into separate batches (#2382) #2383

Closed

2 tasks

georgi-l95 added 12 commits April 23, 2024 16:43

fix rpc batch 1

5d4539b

Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 1 Signed-off-by: georgi-l95 <glazarov95@gmail.com>

fix rpc batch 2

997dbbf

Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 1 Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix rpc batch 2 Signed-off-by: georgi-l95 <glazarov95@gmail.com>

fix tokenCreate

5901cbb

Signed-off-by: georgi-l95 <glazarov95@gmail.com> fix tokenCreate Signed-off-by: georgi-l95 <glazarov95@gmail.com>

fix tokenManagment.spec.ts

ab7c024

Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: update local node Signed-off-by: georgi-l95 <glazarov95@gmail.com>

chore: update @hashgraph/sdk version

7ca5b1b

Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: update sdk Signed-off-by: georgi-l95 <glazarov95@gmail.com>

update logic

a42ad55

Signed-off-by: georgi-l95 <glazarov95@gmail.com> rework ws acceptance tests Signed-off-by: georgi-l95 <glazarov95@gmail.com> add logger Signed-off-by: georgi-l95 <glazarov95@gmail.com>

optimize logic for retrying sendRawTransaction

4fb2fc5

Signed-off-by: georgi-l95 <glazarov95@gmail.com> chore: add missing type Signed-off-by: georgi-l95 <glazarov95@gmail.com> apply more clear logic to condition Signed-off-by: georgi-l95 <glazarov95@gmail.com>

address comments

7743925

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

georgi-l95 force-pushed the bump-local-node-version branch from 4196163 to 7743925 Compare April 23, 2024 13:45

georgi-l95 requested a review from konstantinabl April 23, 2024 13:54

georgi-l95 added 2 commits April 23, 2024 17:19

remove leftover comments

11fb606

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

fix unit tests

d72d1fd

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

konstantinabl previously approved these changes Apr 23, 2024

View reviewed changes

georgi-l95 added 2 commits April 23, 2024 18:40

fix tests

4ffd1a2

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

fix tests

a647b96

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

georgi-l95 dismissed konstantinabl’s stale review via a647b96 April 23, 2024 15:42

georgi-l95 added 2 commits April 23, 2024 19:06

fix rpc batch 3

fc294f9

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

add custom amount for rpc batch 3

82f9370

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

quiet-node approved these changes Apr 23, 2024

View reviewed changes

konstantinabl approved these changes Apr 23, 2024

View reviewed changes

quiet-node merged commit c2867d5 into main Apr 23, 2024
29 of 30 checks passed

quiet-node deleted the bump-local-node-version branch April 23, 2024 18:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: stabilize acceptance tests and update local-node #2255

test: stabilize acceptance tests and update local-node #2255

georgi-l95 commented Mar 28, 2024 •

edited

Loading

github-actions bot commented Mar 28, 2024 •

edited

Loading

codecov-commenter commented Mar 28, 2024 •

edited

Loading

github-actions bot commented Mar 28, 2024 •

edited

Loading

AlfredoG87 left a comment

Nana-EC left a comment

Nana-EC Apr 22, 2024

Nana-EC Apr 22, 2024

georgi-l95 Apr 23, 2024

Nana-EC Apr 22, 2024

georgi-l95 Apr 23, 2024

Nana-EC Apr 22, 2024

georgi-l95 Apr 23, 2024

Nana-EC Apr 22, 2024

georgi-l95 Apr 23, 2024

quiet-node left a comment

sonarcloud bot commented Apr 23, 2024

quiet-node left a comment

test: stabilize acceptance tests and update local-node #2255

test: stabilize acceptance tests and update local-node #2255

Conversation

georgi-l95 commented Mar 28, 2024 • edited Loading

github-actions bot commented Mar 28, 2024 • edited Loading

Tests

codecov-commenter commented Mar 28, 2024 • edited Loading

Codecov Report

github-actions bot commented Mar 28, 2024 • edited Loading

Acceptance Tests

AlfredoG87 left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quiet-node left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Apr 23, 2024

Quality Gate failed

quiet-node left a comment

Choose a reason for hiding this comment

georgi-l95 commented Mar 28, 2024 •

edited

Loading

github-actions bot commented Mar 28, 2024 •

edited

Loading

codecov-commenter commented Mar 28, 2024 •

edited

Loading

github-actions bot commented Mar 28, 2024 •

edited

Loading