fix: SDKClient timeouts are not getting logged with requestIds. #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umped up SDK_REQUEST_TIMEOUT for CI. Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
requested review from
AlfredoG87,
Nana-EC,
a team and
lukelee-sl
as code owners
quiet-node
previously approved these changes
Oct 3, 2024
quiet-node
reviewed
Oct 3, 2024
|
Also please update the PR title. It got cut off |
ebadiere
changed the title
quiet-node
requested changes
Oct 4, 2024
ebadiere
force-pushed
the
3045-SDKClient-timeouts-logging
branch
from
fd38a1a
to
d293121
Compare
Signed-off-by: ebadiere <ebadiere@gmail.com>
|
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3061 +/- ##
=======================================
Coverage 84.83% 84.84%
=======================================
Files 59 59
Lines 3937 3939 +2
Branches 786 788 +2
=======================================
+ Hits 3340 3342 +2
- Misses 357 359 +2
+ Partials 240 238 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ebadiere
added a commit
that referenced
this pull request
Oct 8, 2024
* fix: Enhanced logged warning to include SDKClient error message and bumped up SDK_REQUEST_TIMEOUT for CI. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Removed the increate in sdkClient timeout. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
added a commit
that referenced
this pull request
Oct 9, 2024
…82.0 (#3076) * fix: upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0 Snyk has created this PR to upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0. See this package in npm: @graphprotocol/graph-cli See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/24dd80bc-cab7-4d83-83d7-a604d57322e3?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Skip issue matching check for thirdparty build dependency librar… (#2990) * fix: Skip issue matching check for thirdparty build dependency libraries. We do not control them. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Now validates PRs listed in description by matching contributors in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: SDKClient timeouts are not getting logged with requestIds. (#3061) * fix: Enhanced logged warning to include SDKClient error message and bumped up SDK_REQUEST_TIMEOUT for CI. Signed-off-by: ebadiere <ebadiere@gmail.com> * fix: Removed the increate in sdkClient timeout. Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> --------- Signed-off-by: ebadiere <ebadiere@gmail.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Eric Badiere <ebadiere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped up SDK_REQUEST_TIMEOUT for CI.
Description:
Timeouts on requests happen in both CI and mainnet. The SDKClient timeout message is hard to track because the request ID is not included in the actual timeout message. This change now adds the SDKClientError message to the logged warning that includes the requestId.
Related issue(s):
Fixes #3045
Notes for reviewer:
Checklist