Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pr check ignore issues check external projects #3077

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

ebadiere
Copy link
Collaborator

@ebadiere ebadiere commented Oct 8, 2024

Added additional bypass for snyk PRs.

Related issue(s):

Fixes #2988

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ies.

We do not control them.

Signed-off-by: ebadiere <ebadiere@gmail.com>
… in the repository and not matching PRs with issues from third party projects.

Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
@ebadiere ebadiere requested review from a team as code owners October 8, 2024 18:47
@ebadiere ebadiere self-assigned this Oct 8, 2024
@ebadiere ebadiere added the bug Something isn't working label Oct 8, 2024
@ebadiere ebadiere added this to the 0.58.0 milestone Oct 8, 2024
…rojects

Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Copy link

sonarcloud bot commented Oct 8, 2024

Copy link

github-actions bot commented Oct 8, 2024

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 28,034.3 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.72 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: decreased with 344.06 KB
  • Total Available Size: increased with 2.03 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 64.00 bytes
  • Used Heap Size: decreased with 3.35 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:

    • Space Size: increased with 2.10 MB
    • Space Used Size: increased with 2.01 MB
    • Space Available Size: decreased with 279.22 KB
    • Physical Space Size: increased with 2.10 MB
  • Large Object Space:

    • Space Size: increased with 835.58 KB
    • Space Used Size: increased with 813.50 KB
    • Space Available Size: no changes
    • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

Copy link

github-actions bot commented Oct 8, 2024

Tests

       3 files     299 suites   19s ⏱️
1 354 tests 1 353 ✔️ 1 💤 0
1 363 runs  1 362 ✔️ 1 💤 0

Results for commit d16295c.

@ebadiere ebadiere changed the title 2988 pr check ignore issues check external projects fix: 2988 pr check ignore issues check external projects Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

Acceptance Tests

  19 files  238 suites   30m 58s ⏱️
603 tests 596 ✔️ 4 💤 3
656 runs  648 ✔️ 4 💤 4

Results for commit d16295c.

@quiet-node quiet-node changed the title fix: 2988 pr check ignore issues check external projects fix: pr check ignore issues check external projects Oct 8, 2024
@ebadiere ebadiere merged commit 0ba2162 into main Oct 8, 2024
46 of 47 checks passed
@ebadiere ebadiere deleted the 2988-PR-check-ignore-issues-check-external-projects branch October 8, 2024 23:15
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.84%. Comparing base (9f86d43) to head (d16295c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3077   +/-   ##
=======================================
  Coverage   84.84%   84.84%           
=======================================
  Files          59       59           
  Lines        3939     3939           
  Branches      788      788           
=======================================
  Hits         3342     3342           
  Misses        359      359           
  Partials      238      238           
Flag Coverage Δ
relay 84.95% <ø> (ø)
server 83.43% <ø> (ø)
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

The PR check in CI needs to be updated to ignore the issues check on external dependencies.
3 participants