Add HTS Precompile Acceptance Tests for Expiry Info methods #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgi-l95
requested review from
Ivo-Yankov,
natanasow,
Nana-EC and
lukelee-sl
georgi-l95
changed the title
Nana-EC
requested changes
Aug 24, 2022
| const tokenExpiryInfo = (await getTokenExpiryInfoTx.wait()).events.filter(e => e.event === 'TokenExpiryInfo')[0].args.expiryInfo; | ||
|
|
||
| expect(responseCode).to.equal(TX_SUCCESS_CODE); | ||
| expect(tokenExpiryInfo.autoRenewPeriod).to.equal(7776000); |
There was a problem hiding this comment.
nit: add check for second also here and below
| expect(tokenExpiryInfo.autoRenewAccount).to.equal(NftHTSTokenContractAddress); | ||
| }); | ||
|
|
||
| it('should be able to update fungible token expiry info', async function() { |
There was a problem hiding this comment.
Improvement suggestion.
Change these 4 tests into 2 tests
Test 1 ( combines your current test 1 and 3)
- confirm
getTokenExpiryInfoPublic()for FT - update expiry info using
updateTokenExpiryInfoPublic() - confirm updated info
Test 2 ( combines your current test 2 and 4)
- confirm
getTokenExpiryInfoPublic()for NFT - update expiry info using
updateTokenExpiryInfoPublic() - confirm updated info
There was a problem hiding this comment.
Done. Updated the flow.
|
Moving this PR to draft, until we get the 0.30.0 services tag next sprint. |
Codecov Report
@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 12 12
Lines 923 923
Branches 144 144
=======================================
Hits 705 705
Misses 165 165
Partials 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
georgi-l95
force-pushed
the
408-htsprecompile-acceptance-test-for-auto-renew-methods
branch
from
7f14fc3
to
0aa1909
Compare
Signed-off-by: georgi-l95 <glazarov95@gmail.com> update flow Signed-off-by: georgi-l95 <glazarov95@gmail.com> Enable tests Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> test refactor Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> Acceptance test index rework Signed-off-by: georgi-l95 <glazarov95@gmail.com> remove typo Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
force-pushed
the
408-htsprecompile-acceptance-test-for-auto-renew-methods
branch
from
e5b1e86
to
bbd6115
Compare
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Sep 9, 2022
georgi-l95
deleted the
408-htsprecompile-acceptance-test-for-auto-renew-methods
branch
dimitrovmaksim
pushed a commit
that referenced
this pull request
Sep 12, 2022
* add tests for expiryInfo Signed-off-by: georgi-l95 <glazarov95@gmail.com> update flow Signed-off-by: georgi-l95 <glazarov95@gmail.com> Enable tests Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> test refactor Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> Acceptance test index rework Signed-off-by: georgi-l95 <glazarov95@gmail.com> remove typo Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> * change Signed-off-by: georgi-l95 <glazarov95@gmail.com> * bump services version and activate some tests Signed-off-by: georgi-l95 <glazarov95@gmail.com> * revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
dimitrovmaksim
pushed a commit
that referenced
this pull request
Sep 16, 2022
* add tests for expiryInfo Signed-off-by: georgi-l95 <glazarov95@gmail.com> update flow Signed-off-by: georgi-l95 <glazarov95@gmail.com> Enable tests Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> test refactor Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> Acceptance test index rework Signed-off-by: georgi-l95 <glazarov95@gmail.com> remove typo Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> * change Signed-off-by: georgi-l95 <glazarov95@gmail.com> * bump services version and activate some tests Signed-off-by: georgi-l95 <glazarov95@gmail.com> * revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
dimitrovmaksim
pushed a commit
that referenced
this pull request
Sep 16, 2022
* add tests for expiryInfo Signed-off-by: georgi-l95 <glazarov95@gmail.com> update flow Signed-off-by: georgi-l95 <glazarov95@gmail.com> Enable tests Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com> test refactor Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> Acceptance test index rework Signed-off-by: georgi-l95 <glazarov95@gmail.com> remove typo Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> test Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> x Signed-off-by: georgi-l95 <glazarov95@gmail.com> * change Signed-off-by: georgi-l95 <glazarov95@gmail.com> * bump services version and activate some tests Signed-off-by: georgi-l95 <glazarov95@gmail.com> * revert some changes Signed-off-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: georgi-l95 glazarov95@gmail.com
Description:
Adds tests for:
getTokenExpiryInfo(address)updateTokenExpiryInfo(address, Expiry)Related issue(s):
Fixes #408
Notes for reviewer:
Version of network node is bumped to 0.30.0-alpha.2 . Some adjustments before starting the node, so that acceptance tests can run. This unblocks all other PRs open for HTS Precompile tests.
Checklist