Add HTS Precompile tests for token check methods #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natanasow
requested review from
georgi-l95,
Nana-EC,
Ivo-Yankov and
dimitrovmaksim
and removed request for
georgi-l95
Nana-EC
requested changes
Aug 24, 2022
| const tokenType = txReceipt.events.filter(e => e.event === 'TokenType')[0].args.tokenType; | ||
| expect(tokenType).to.equal(0); | ||
| }); | ||
| it('should returns 1 for getTokenType with passed HTS nft token', async function() { |
There was a problem hiding this comment.
Suggested change
| it('should returns 1 for getTokenType with passed HTS nft token', async function() { | |
| it('should return 1 for getTokenType with passed HTS nft token', async function() { |
| const tokenType = txReceipt.events.filter(e => e.event === 'TokenType')[0].args.tokenType; | ||
| expect(tokenType).to.equal(1); | ||
| }); | ||
| it('should throws an exception for getTokenType with passed contract address', async function() { |
There was a problem hiding this comment.
Suggested change
| it('should throws an exception for getTokenType with passed contract address', async function() { | |
| it('should throw an exception for getTokenType with passed contract address', async function() { |
| const isTokenFlag = txReceipt.events.filter(e => e.event === 'IsToken')[0].args.isToken; | ||
| expect(isTokenFlag).to.equal(true); | ||
| }); | ||
| it('should returns 0 for getTokenType with passed HTS token', async function() { |
There was a problem hiding this comment.
Suggested change
| it('should returns 0 for getTokenType with passed HTS token', async function() { | |
| it('should returns 0 for getTokenType with passed FUNGIBLE_COMMON token', async function() { |
| const tokenType = txReceipt.events.filter(e => e.event === 'TokenType')[0].args.tokenType; | ||
| expect(tokenType).to.equal(0); | ||
| }); | ||
| it('should returns 1 for getTokenType with passed HTS nft token', async function() { |
There was a problem hiding this comment.
Suggested change
| it('should returns 1 for getTokenType with passed HTS nft token', async function() { | |
| it('should returns 1 for getTokenType with passed HTS NON_FUNGIBLE_UNIQUE token', async function() { |
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Codecov ReportBase: 76.38% // Head: 76.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
=======================================
Coverage 76.38% 76.38%
=======================================
Files 12 12
Lines 923 923
Branches 144 144
=======================================
Hits 705 705
Misses 165 165
Partials 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
…n-check-methods # Conflicts: # packages/server/tests/acceptance/htsPrecompile.spec.ts # packages/server/tests/contracts/BaseHTS.json # packages/server/tests/contracts/BaseHTS.sol # packages/server/tests/contracts/HederaTokenService.sol # packages/server/tests/contracts/IHederaTokenService.sol
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Nana-EC
previously approved these changes
Sep 14, 2022
…n-check-methods # Conflicts: # packages/server/tests/contracts/BaseHTS.json
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Ivo-Yankov
approved these changes
Sep 15, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
natanasow
deleted the
411-add-htsprecompile-tests-support-for-token-check-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nikolay n.atanasow94@gmail.com
Description:
Add support for the token verifications:
Related issue(s):
Fixes #411
Notes for reviewer:
Checklist