Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DApp Test stuck running bootstrap action step #503

Merged
merged 19 commits into from
Sep 8, 2022

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Sep 7, 2022

Signed-off-by: nikolay n.atanasow94@gmail.com

Description:
DApp tests were stalling due to

  • bump hashgraph/hedera-local to 1.2.0
  • Update npx hedera-local commands to use npx hedera
  • Bump server acceptance test prerequisite.ts to use services 0.30.0-alpha.0 and mirror node 0.64.0-beta2
  • Update restart command from npx hedera-local to npx hedera restart -h localhost -d

Related issue(s):

Fixes #499

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Nana-EC and others added 3 commits August 30, 2022 13:03
Bump 0.7.0-rc1

Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
BUmp 0.7.0


Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #503 (ef0638a) into main (52b5ed4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          12       12           
  Lines         923      923           
  Branches      144      144           
=======================================
  Hits          705      705           
  Misses        165      165           
  Partials       53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@natanasow natanasow marked this pull request as draft September 7, 2022 15:50
@natanasow natanasow changed the base branch from release/0.7 to main September 8, 2022 08:09
# Conflicts:
#	docs/openrpc.json
#	helm-chart/Chart.yaml
#	package-lock.json
#	packages/relay/package.json
#	packages/server/package.json
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@natanasow natanasow marked this pull request as ready for review September 8, 2022 11:28
@Nana-EC Nana-EC added bug Something isn't working limechain P1 labels Sep 8, 2022
@Nana-EC Nana-EC added the process Build, test and deployment-process related tasks label Sep 8, 2022
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

process.env['MIRROR_IMAGE_TAG'] = '0.62.0-rc1';
process.env['NETWORK_NODE_IMAGE_TAG'] = '0.30.0-alpha.0';
process.env['HAVEGED_IMAGE_TAG'] = '0.30.0-alpha.0';
process.env['MIRROR_IMAGE_TAG'] = '0.64.0-beta2';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GA version is now available

Suggested change
process.env['MIRROR_IMAGE_TAG'] = '0.64.0-beta2';
process.env['MIRROR_IMAGE_TAG'] = '0.64.0';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update in my PR

@Nana-EC
Copy link
Collaborator

Nana-EC commented Sep 8, 2022

@natanasow please update PR comments also. I did a partial one to help merge the PR but please fill in the first line :)
Thanks for the fix

@Nana-EC Nana-EC added this to the 0.8.0 milestone Sep 8, 2022
@Nana-EC Nana-EC merged commit 7c31c74 into main Sep 8, 2022
@Nana-EC Nana-EC deleted the 499-dapp-test-stuck-running-bootstrap branch September 8, 2022 16:15
@Nana-EC Nana-EC mentioned this pull request Sep 12, 2022
2 tasks
dimitrovmaksim pushed a commit that referenced this pull request Sep 16, 2022
- bump hashgraph/hedera-local to 1.2.0
- Update `npx hedera-local` commands to use `npx hedera`
- Bump server acceptance test `prerequisite.ts` to use services `0.30.0-alpha.0` and mirror node `0.64.0-beta2`
- Update restart command from `npx hedera-local` to `npx hedera restart -h localhost -d`

Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com>
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
dimitrovmaksim pushed a commit that referenced this pull request Sep 16, 2022
- bump hashgraph/hedera-local to 1.2.0
- Update `npx hedera-local` commands to use `npx hedera`
- Bump server acceptance test `prerequisite.ts` to use services `0.30.0-alpha.0` and mirror node `0.64.0-beta2`
- Update restart command from `npx hedera-local` to `npx hedera restart -h localhost -d`

Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Co-authored-by: Nana Essilfie-Conduah <56320167+Nana-EC@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working limechain P1 process Build, test and deployment-process related tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

DApp Test stuck running bootstrap action step
3 participants