-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getLogs add support for block tags #518
Conversation
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
Codecov ReportBase: 76.38% // Head: 76.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
- Coverage 76.38% 76.01% -0.37%
==========================================
Files 12 12
Lines 923 938 +15
Branches 144 148 +4
==========================================
+ Hits 705 713 +8
- Misses 165 171 +6
- Partials 53 54 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@@ -117,4 +119,9 @@ export const predefined = { | |||
code: -32001, | |||
message: 'Requested resource not found' | |||
}), | |||
'RANGE_TOO_LONG': new JsonRpcError({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: let's use large
instead of long
I'll address the comments and open a new PR, because the commits in this one aren't verified as well. |
Closing in favour of #532 |
Signed-off-by: Maksim Dimitrov dimitrov.maksim@gmail.com
Description:
ETH_GET_LOGS_BLOCK_RANGE_LIMIT
env variableRelated issue(s):
Fixes #472
Notes for reviewer:
Maybe we should set a max block range limit?
Checklist