Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IERC transferFrom to HTS Precompile Acceptance Tests #523

Merged

Conversation

georgi-l95
Copy link
Collaborator

@georgi-l95 georgi-l95 commented Sep 15, 2022

Signed-off-by: georgi-l95 glazarov95@gmail.com

Description:
Adds coverage for the following:

- approveNFT(address token, address spender, uint256 tokenId);
- IERC20(token).transferFrom(sender, recipient, amount);
- IERC721(token).transferFrom(from, to, tokenId);
- IERC721(token).balanceOf(address owner);
- IERC721(token).getApproved(uint256 tokenId);

Related issue(s):

Fixes #497

Notes for reviewer:
Bump dapp boostrap wait for local-node from 10 to 20 sec, because sometimes 10 is not enough.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@georgi-l95 georgi-l95 changed the title add transferFrom coverage Add IERC transferFrom to HTS Precompile Acceptance Tests Sep 15, 2022
@georgi-l95 georgi-l95 self-assigned this Sep 15, 2022
@georgi-l95 georgi-l95 added this to the 0.8.0 milestone Sep 15, 2022
@georgi-l95 georgi-l95 added enhancement New feature or request limechain P1 process Build, test and deployment-process related tasks labels Sep 15, 2022
@georgi-l95 georgi-l95 requested review from Nana-EC, Ivo-Yankov and natanasow and removed request for Nana-EC and Ivo-Yankov September 15, 2022 10:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Base: 76.38% // Head: 76.38% // No change to project coverage 👍

Coverage data is based on head (dd1ee8c) compared to base (400a1e7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          12       12           
  Lines         923      923           
  Branches      144      144           
=======================================
  Hits          705      705           
  Misses        165      165           
  Partials       53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

test

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

fix

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 force-pushed the add-ierc721-transferFrom-to-hts-precompile-acceptance-tests branch from ecee529 to c53b845 Compare September 15, 2022 14:58
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@georgi-l95 georgi-l95 marked this pull request as ready for review September 16, 2022 10:08
@georgi-l95 georgi-l95 merged commit 41e0714 into main Sep 16, 2022
@georgi-l95 georgi-l95 deleted the add-ierc721-transferFrom-to-hts-precompile-acceptance-tests branch September 16, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limechain P1 process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IERC transferFrom to htsPrecompile approval acceptance tests
3 participants