Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

540 capture calldata cp #546

Merged
merged 6 commits into from
Sep 21, 2022
Merged

540 capture calldata cp #546

merged 6 commits into from
Sep 21, 2022

Conversation

lukelee-sl
Copy link
Member

Description:
Cherry pick changes for logging calldata information to release/0.8

Fixes #540

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

lukelee-sl and others added 6 commits September 20, 2022 20:24
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Log details about the file created for callData when calling a transaction.

Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
@lukelee-sl lukelee-sl self-assigned this Sep 21, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 76.75% // Head: 74.92% // Decreases project coverage by -1.83% ⚠️

Coverage data is based on head (1149223) compared to base (abab2db).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/0.8     #546      +/-   ##
===============================================
- Coverage        76.75%   74.92%   -1.84%     
===============================================
  Files               12       12              
  Lines              938      961      +23     
  Branches           144      150       +6     
===============================================
  Hits               720      720              
- Misses             171      194      +23     
  Partials            47       47              
Impacted Files Coverage Δ
packages/relay/src/lib/clients/sdkClient.ts 6.81% <0.00%> (-1.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nana-EC Nana-EC added enhancement New feature or request P1 labels Sep 21, 2022
@Nana-EC Nana-EC added this to the 0.8.0 milestone Sep 21, 2022
@lukelee-sl lukelee-sl merged commit 11117a3 into release/0.8 Sep 21, 2022
@lukelee-sl lukelee-sl deleted the 540-capture-calldata-cp branch September 21, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants